Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Trimmed down permission for dashboard service account #2571

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Trimmed down permission for dashboard service account #2571

merged 1 commit into from
Mar 30, 2018

Conversation

EPinci
Copy link
Contributor

@EPinci EPinci commented Mar 30, 2018

What this PR does / why we need it:

This PR trims down the dashboard service account to the minimum possible per https://github.com/kubernetes/dashboard/wiki/Access-control#default-dashboard-privileges .
Current permission allow users to skip dashboard authentication and inherit cluster-admin priviledges nullifying the login process and RBAC resulting in an unsecure cluster.
With the proposed configuration, skipping login results in no permissions.
For development clusters, users can still reinstate previous permission manually granting cluster-admin permission to the dashboard service account.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2425

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Security: skipping kubernetes dashboard's login now effectively results in no permissions.
Logged in user will receive permission per RBAC profile.

@msftclas
Copy link

msftclas commented Mar 30, 2018

CLA assistant check
All CLA requirements met.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit 3f6b25a into Azure:master Mar 30, 2018
@EPinci EPinci deleted the dashboard branch April 2, 2018 18:36
@mpalumbo7
Copy link
Contributor

@jackfrancis
Copy link
Member

@ewok2030 Thanks! fixed here: #2816

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard Service Account Role
4 participants