Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

RBAC-enabled dashboard for k8s 1.9 and greater #2816

Merged
merged 2 commits into from
May 4, 2018

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Apr 30, 2018

What this PR does / why we need it: RBAC-enabled dashboard config for 1.9 and greater k8s clusters

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2808

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

RBAC-enabled dashboard for 1.9 and greater

@ghost ghost assigned jackfrancis Apr 30, 2018
@ghost ghost added the in progress label Apr 30, 2018
@jackfrancis
Copy link
Member Author

@lachie83 @slack FYI this PR basically opines: to use the dashboard in 1.9 and greater you'll need to adhere to this RBAC schema

@CecileRobertMichon
Copy link
Contributor

How does this fit with #2808 ?

@jackfrancis
Copy link
Member Author

@CecileRobertMichon it fixes it :) (added to description)

@mpalumbo7
Copy link
Contributor

Weird. What is causing the e2e tests to fail?

@jackfrancis
Copy link
Member Author

@ewok2030 E2E test is also broken :) will fix and commit to this PR branch

@codecov
Copy link

codecov bot commented May 3, 2018

Codecov Report

Merging #2816 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2816      +/-   ##
==========================================
- Coverage   46.92%   46.91%   -0.01%     
==========================================
  Files          86       86              
  Lines       12802    12786      -16     
==========================================
- Hits         6007     5999       -8     
+ Misses       6240     6232       -8     
  Partials      555      555
Impacted Files Coverage Δ
pkg/operations/kubernetesupgrade/upgrader.go 56.48% <0%> (-0.84%) ⬇️
pkg/api/convertertoapi.go 56.51% <0%> (-0.06%) ⬇️
pkg/api/types.go 28.88% <0%> (ø) ⬆️
pkg/api/vlabs/types.go 18.57% <0%> (ø) ⬆️
pkg/api/converterfromapi.go 9.87% <0%> (+0.01%) ⬆️
pkg/acsengine/engine.go 62.82% <0%> (+0.04%) ⬆️
pkg/acsengine/defaults.go 62.83% <0%> (+0.08%) ⬆️
pkg/api/vlabs/validate.go 43.22% <0%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3a804d...7885503. Read the comment docs.

@mpalumbo7
Copy link
Contributor

@jackfrancis Anything left blocking this merge?....I'm gonna have to learn Go so I can stop asking for others to fix the things I would like fixed. :)

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit 057b045 into Azure:master May 4, 2018
@ghost ghost removed the in progress label May 4, 2018
@jackfrancis jackfrancis deleted the k8s-dashboard-1.9-and-greater branch May 4, 2018 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants