Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Update docs to note about single-line-Base64 for k8s certs from KeyVault #481

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Update docs to note about single-line-Base64 for k8s certs from KeyVault #481

merged 1 commit into from
Apr 11, 2017

Conversation

ashb
Copy link
Contributor

@ashb ashb commented Apr 11, 2017

The usage of these values in the template needs the value to be base64 encoded (which az keyvault secret set does support) and all on a single line (which it does not) otherwise it is not valid YAML and cloud-init will fail to process it.

It might be possible to use the [base64()] function in the template instead of this, but for now updating the docs is better than making everyone figure it out for themselves.


This change is Reviewable

@msftclas
Copy link

@ashb,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@acs-bot
Copy link

acs-bot commented Apr 11, 2017

Can one of the admins verify this patch?

The usage of these values in the template needs the value to be base64
encoded (which `az keyvault secret set` does support) _and_ all on a
single line (which it does not) otherwise it is not valid YAML and
cloud-init will fail to process it.
Copy link
Contributor

@JackQuincy JackQuincy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackQuincy JackQuincy merged commit 186f912 into Azure:master Apr 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants