This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: container monitoring addon supports other Azure clouds #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run pr-e2e |
|
Commenter does not have sufficient privileges for PR 2031 in repo Azure/aks-engine |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mboersma
changed the title
jackfrancis
reviewed
Oct 1, 2019
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jackfrancis, Thanks for reviewing this PR. I have fixed your comments. If you dont have any other feedback, please help on merging this PR. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ganga1980, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Container monitoring addon supported AzureChinaCloud and AzureUSGovernmentCloud in addition to Azure Public cloud. This PR has all required changes to work in AzureChinaCloud and AzureUSGovernmentCloud environments.
Issue Fixed:
Requirements:
Notes: