feat: add support for single stack IPv6 #2781

aramase · 2020-02-25T07:14:19Z

Reason for Change:

Add support for single-stack IPv6 cluster in order to run conformance tests and graduate IPv6 to beta in kubernetes.

API model - https://gist.github.com/aramase/a19fcbf1f309dab99600ee9c0d700fce

Issue Fixed:

Requirements:

uses conventional commit messages
includes documentation
adds unit tests
tested upgrade from previous version

Notes:

acs-bot · 2020-02-25T07:17:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aramase
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: patricklang

If they are not already assigned, you can assign the PR to them by writing /assign @patricklang in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov · 2020-02-25T22:18:56Z

Codecov Report

Merging #2781 into master will increase coverage by 0.01%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master    #2781      +/-   ##
==========================================
+ Coverage   72.47%   72.48%   +0.01%     
==========================================
  Files         140      140              
  Lines       25589    25658      +69     
==========================================
+ Hits        18545    18599      +54     
- Misses       5976     5987      +11     
- Partials     1068     1072       +4

pkg/api/vlabs/validate.go

jackfrancis · 2020-03-03T01:19:14Z

@aramase Is this ready for final review?

aramase · 2020-03-03T06:58:31Z

@jackfrancis yes, this is ready for review.

aramase · 2020-03-04T16:57:08Z

/cc @jackfrancis

aramase · 2020-03-04T23:32:29Z

@jackfrancis Please review this when you get a chance. I would like to get it merged and then setup conformance job in prow for single stack IPv6 cluster. Need that for graduation of IPv6 to beta.

jackfrancis · 2020-03-06T00:13:52Z

parts/k8s/addons/1.18/kubernetesmasteraddons-kube-proxy-daemonset.yaml

@@ -9,6 +9,15 @@ data:
      kubeconfig: /var/lib/kubelet/kubeconfig
    clusterCIDR: "{{ContainerConfig "cluster-cidr"}}"
    mode: "{{ContainerConfig "proxy-mode"}}"
+    {{- if ContainerConfig "bind-address"}}


So go template if operates against strings according to "" = false and any non-empty string = true ?

@jackfrancis correct, if it's "" then it's ignored.

Looked up and verified in the actual docs as well :)

pkg/api/vlabs/validate.go

jackfrancis · 2020-03-06T00:24:48Z

pkg/api/addons.go

+	// set host network to true for single stack IPv6 as the the nameserver is currently
+	// IPv4 only. By setting it to host network, we can leverage the host routes to successfully
+	// resolve dns.
+	if cs.Properties.FeatureFlags.IsFeatureEnabled("EnableIPv6Only") {


We should add UT coverage to addons_test.go for these ipv6 scenarios. Lemme know if you want help, it's 4k+ lines of UT coverage :)

Let me take a stab at it, will ping you if you I need help :)

@jackfrancis added the tests, PTAL!

aramase · 2020-03-06T21:26:24Z

pkg/api/addons_test.go

 	var ret []KubernetesAddon
 	defaults := getDefaultAddons(version, kubernetesImageBase, kubernetesImageBaseType)
-	for _, addonOverride := range addons {


@jackfrancis With this logic, if overwriteDefaultAddons is called with more than 1 overwrite addon, it would result in duplicate values for overwriteAddons[1:]. So I've updated the logic to just do a single pass of the array.

yikes, thanks!

jackfrancis

/lgtm

(cherry picked from commit 1b9beb4)

* feat: add support for Kubernetes 1.18.0-beta.1 (#2791) * feat: add support for Kubernetes 1.18.0-beta.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md/#v1180-beta1 * fix: windows support .zip URL (cherry picked from commit 34706cf) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * test: fix test TestGetProvisionScriptParametersCommon and TestGetK8sVersionComponents * feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457) * Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes * fix linting errors * fixing comments per CR feedback (cherry picked from commit 8be7000) * feat: Experimental support for Windows+ContainerD (#1322) (cherry picked from commit b068aa7) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com> Co-authored-by: Mark Rossetti <marosset@microsoft.com>

(cherry picked from commit 1b9beb4)

…3076) * test: fix test TestGetK8sVersionComponents and TestGetProvisionScriptParametersCommon * feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457) * Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes * fix linting errors * fixing comments per CR feedback (cherry picked from commit 8be7000) * feat: add support for Kubernetes 1.18.0-beta.1 (#2791) * feat: add support for Kubernetes 1.18.0-beta.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md/#v1180-beta1 * fix: windows support .zip URL (cherry picked from commit 34706cf) * feat: Experimental support for Windows+ContainerD (#1322) (cherry picked from commit b068aa7) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * fix: make build with go 1.14 (#3005) (cherry picked from commit 509bc9c) * feat: add support for Kubernetes 1.18.1 (#3045) * feat: add support for Kubernetes 1.18.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180 * ci: test PRs with k8s 1.18 (cherry picked from commit 66ff61c) Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>

(cherry picked from commit 1b9beb4)

…18.2 (#3194) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * fix: make build with go 1.14 (#3005) (cherry picked from commit 509bc9c) * feat: add support for Kubernetes 1.18.1 (#3045) * feat: add support for Kubernetes 1.18.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180 * ci: test PRs with k8s 1.18 (cherry picked from commit 66ff61c) * feat: add support for Kubernetes 1.18.2 (#3089) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1181 (cherry picked from commit 8ebece1) * Revert "Revert windowszip path" This reverts commit 8db438e. * Update KubeBinariesSASURLBase to new path. Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com> Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>

acs-bot added do-not-merge/work-in-progress size/L labels Feb 25, 2020

aramase force-pushed the ipv6 branch 2 times, most recently from dd24886 to 48d7c66 Compare February 25, 2020 17:25

aramase mentioned this pull request Feb 25, 2020

IPv6 support added kubernetes/enhancements#508

Closed

aramase force-pushed the ipv6 branch 3 times, most recently from d766f5e to 3007740 Compare February 25, 2020 21:57

aramase force-pushed the ipv6 branch 2 times, most recently from 51436ea to f5cba91 Compare February 26, 2020 02:25

aojea reviewed Feb 26, 2020

View reviewed changes

pkg/api/vlabs/validate.go Outdated Show resolved Hide resolved

aojea mentioned this pull request Feb 29, 2020

[WIP] Enable IPv6 only kubernetes clusters #2027

Closed

4 tasks

aramase force-pushed the ipv6 branch from f5cba91 to 7910f8d Compare March 2, 2020 18:44

aramase changed the title ~~[WIP] feat: add support for single stack IPv6~~ feat: add support for single stack IPv6 Mar 2, 2020

aramase removed the do-not-merge/work-in-progress label Mar 3, 2020

aramase added 2 commits March 5, 2020 12:34

add support for single stack IPv6

ee31118

fix template

9e57ccb

aramase force-pushed the ipv6 branch 3 times, most recently from 38e1686 to 846ae94 Compare March 5, 2020 20:55

add ipv6 for masq agent

7422876

aramase force-pushed the ipv6 branch from 846ae94 to 7422876 Compare March 5, 2020 21:29

jackfrancis reviewed Mar 6, 2020

View reviewed changes

pkg/api/vlabs/validate.go Show resolved Hide resolved

jackfrancis reviewed Mar 6, 2020

View reviewed changes

aramase commented Mar 6, 2020

View reviewed changes

add tests

599dd28

aramase force-pushed the ipv6 branch from 26d115d to 599dd28 Compare March 6, 2020 21:36

jackfrancis approved these changes Mar 6, 2020

View reviewed changes

jackfrancis merged commit 1b9beb4 into Azure:master Mar 6, 2020

aramase deleted the ipv6 branch March 6, 2020 23:24

fmotrifork mentioned this pull request Mar 23, 2020

aks-engine 0.48.0 fishworks/fish-food#639

Merged

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Mar 29, 2020

feat: add support for single stack IPv6 (Azure#2781)

9f3c02f

(cherry picked from commit 1b9beb4)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Mar 30, 2020

feat: add support for single stack IPv6 (Azure#2781)

4e690d1

(cherry picked from commit 1b9beb4)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Mar 30, 2020

feat: add support for single stack IPv6 (Azure#2781)

e036001

(cherry picked from commit 1b9beb4)

jsturtevant mentioned this pull request Apr 10, 2020

Add IPv6 support kubernetes-sigs/cluster-api-provider-azure#318

Closed

bowen5 added a commit to bowen5/aks-engine that referenced this pull request Apr 16, 2020

feat: add support for single stack IPv6 (Azure#2781)

7a467e6

(cherry picked from commit 1b9beb4)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Apr 16, 2020

feat: add support for single stack IPv6 (Azure#2781)

96d1855

(cherry picked from commit 1b9beb4)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request Apr 26, 2020

feat: add support for single stack IPv6 (Azure#2781)

2d8845f

(cherry picked from commit 1b9beb4)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request May 5, 2020

feat: add support for single stack IPv6 (Azure#2781)

c5ace7a

(cherry picked from commit 1b9beb4)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request May 5, 2020

feat: add support for single stack IPv6 (Azure#2781)

c06138c

(cherry picked from commit 1b9beb4)

bowen5 pushed a commit to bowen5/aks-engine that referenced this pull request May 5, 2020

feat: add support for single stack IPv6 (Azure#2781)

77d063e

(cherry picked from commit 1b9beb4)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for single stack IPv6 #2781

feat: add support for single stack IPv6 #2781

aramase commented Feb 25, 2020 •

edited

acs-bot commented Feb 25, 2020

codecov bot commented Feb 25, 2020 •

edited

jackfrancis commented Mar 3, 2020

aramase commented Mar 3, 2020

aramase commented Mar 4, 2020

aramase commented Mar 4, 2020

jackfrancis Mar 6, 2020

aramase Mar 6, 2020

jackfrancis Mar 6, 2020

jackfrancis Mar 6, 2020

aramase Mar 6, 2020

aramase Mar 6, 2020

aramase Mar 6, 2020

jackfrancis Mar 6, 2020

jackfrancis left a comment

feat: add support for single stack IPv6 #2781

feat: add support for single stack IPv6 #2781

Conversation

aramase commented Feb 25, 2020 • edited

acs-bot commented Feb 25, 2020

codecov bot commented Feb 25, 2020 • edited

Codecov Report

jackfrancis commented Mar 3, 2020

aramase commented Mar 3, 2020

aramase commented Mar 4, 2020

aramase commented Mar 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jackfrancis left a comment

Choose a reason for hiding this comment

aramase commented Feb 25, 2020 •

edited

codecov bot commented Feb 25, 2020 •

edited