This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: installing csi-proxy for windows at node deployment time #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @kkmsft @andyzhangx @jackfrancis @mboersma I also updated the powershell to set kubelet service to depend on csi-proxy-server service if enabled (per KK's feedback on other PR) |
Codecov Report
@@ Coverage Diff @@
## master #2930 +/- ##
==========================================
- Coverage 72.5% 72.47% -0.03%
==========================================
Files 141 141
Lines 25744 25928 +184
==========================================
+ Hits 18666 18792 +126
- Misses 5998 6040 +42
- Partials 1080 1096 +16 |
jackfrancis
reviewed
Mar 19, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xuto2
pushed a commit
that referenced
this pull request
Mar 31, 2020
* feat: add support for Kubernetes 1.18.0-beta.1 (#2791) * feat: add support for Kubernetes 1.18.0-beta.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md/#v1180-beta1 * fix: windows support .zip URL (cherry picked from commit 34706cf) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * test: fix test TestGetProvisionScriptParametersCommon and TestGetK8sVersionComponents * feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457) * Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes * fix linting errors * fixing comments per CR feedback (cherry picked from commit 8be7000) * feat: Experimental support for Windows+ContainerD (#1322) (cherry picked from commit b068aa7) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com> Co-authored-by: Mark Rossetti <marosset@microsoft.com>
xuto2
pushed a commit
that referenced
this pull request
Apr 22, 2020
…3076) * test: fix test TestGetK8sVersionComponents and TestGetProvisionScriptParametersCommon * feat: Adding WindowsNodeReset.ps1 script to reset/cleanup state for nodes (#2457) * Adding WindowsNodeReset.ps1 script to reset/cleanup state for windox^C nodes * fix linting errors * fixing comments per CR feedback (cherry picked from commit 8be7000) * feat: add support for Kubernetes 1.18.0-beta.1 (#2791) * feat: add support for Kubernetes 1.18.0-beta.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md/#v1180-beta1 * fix: windows support .zip URL (cherry picked from commit 34706cf) * feat: Experimental support for Windows+ContainerD (#1322) (cherry picked from commit b068aa7) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * fix: make build with go 1.14 (#3005) (cherry picked from commit 509bc9c) * feat: add support for Kubernetes 1.18.1 (#3045) * feat: add support for Kubernetes 1.18.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180 * ci: test PRs with k8s 1.18 (cherry picked from commit 66ff61c) Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
xuto2
pushed a commit
that referenced
this pull request
May 5, 2020
…18.2 (#3194) * feat: add support for single stack IPv6 (#2781) (cherry picked from commit 1b9beb4) * feat: allow iptables mode for dualstack 1.18+ (#2882) (cherry picked from commit ff5362e) * chore: update cluster-autoscaler for k8s 1.18 (#2901) See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.0 (cherry picked from commit 0cc985d) * feat: installing csi-proxy for windows at node deployment time (#2930) (cherry picked from commit 13e72f2) * feat: add support for Kubernetes 1.18.0 (#2957) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md (cherry picked from commit 6dadaf0) * fix: make build with go 1.14 (#3005) (cherry picked from commit 509bc9c) * feat: add support for Kubernetes 1.18.1 (#3045) * feat: add support for Kubernetes 1.18.1 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1180 * ci: test PRs with k8s 1.18 (cherry picked from commit 66ff61c) * feat: add support for Kubernetes 1.18.2 (#3089) See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v1181 (cherry picked from commit 8ebece1) * Revert "Revert windowszip path" This reverts commit 8db438e. * Update KubeBinariesSASURLBase to new path. Co-authored-by: Anish Ramasekar <anish.ramasekar@gmail.com> Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Mark Rossetti <marosset@microsoft.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Redo of #2854
Add support for installing csi-proxy for windows at node-deloyment time.
Issue Fixed:
Requirements:
Notes: