Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: refresh documentation store #3177

Merged
merged 4 commits into from
May 4, 2020
Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR is the result of a focused refresh of all (well, most) documentation in the repo. It should be reviewed for sanity in terms of truthful corrections to narrative, and amendments/standardizations to various references, and some light grammar (intended) improvements.

Issue Fixed:

Fixes #3170

Requirements:

Notes:

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #3177 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3177   +/-   ##
=======================================
  Coverage   71.23%   71.24%           
=======================================
  Files         147      147           
  Lines       25745    25753    +8     
=======================================
+ Hits        18340    18348    +8     
  Misses       6268     6268           
  Partials     1137     1137           
Impacted Files Coverage Δ
cmd/addpool.go 18.91% <ø> (ø)
cmd/rotate_certs.go 67.93% <ø> (ø)
cmd/scale.go 12.39% <ø> (ø)
cmd/upgrade.go 44.56% <ø> (ø)
cmd/version.go 100.00% <ø> (ø)
cmd/deploy.go 62.61% <100.00%> (ø)
cmd/generate.go 50.38% <100.00%> (ø)
pkg/engine/templates_generated.go 38.36% <0.00%> (ø)
pkg/api/vlabs/validate.go 80.19% <0.00%> (+0.03%) ⬆️
pkg/api/defaults-kubelet.go 96.66% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29dd816...44be2c6. Read the comment docs.

docs/topics/hybrid-environment.md Outdated Show resolved Hide resolved
docs/topics/hybrid-environment.md Outdated Show resolved Hide resolved
docs/topics/monitoring.md Show resolved Hide resolved
docs/tutorials/quickstart.md Show resolved Hide resolved
docs/tutorials/quickstart.md Outdated Show resolved Hide resolved
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented May 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit b357dc4 into Azure:master May 4, 2020
@jackfrancis jackfrancis deleted the docs-refresh branch May 4, 2020 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation and validation for "Location" field
3 participants