This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: update the flag due to using higher version of csi livenessprobe #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feiskyer
previously approved these changes
Sep 1, 2020
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mboersma
dismissed stale reviews from chewong, andyzhangx, and feiskyer
via
f939efd
|
@chewong I ran |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #3770 +/- ##
=======================================
Coverage 73.20% 73.20%
=======================================
Files 148 148
Lines 25375 25375
=======================================
Hits 18576 18576
Misses 5663 5663
Partials 1136 1136
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, jackfrancis, ZeroMagic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The version of CSI livenessprobe are different from AzureDiskFile CSI Drivers and Secret Store CSI Drivers currently. Tested the AzureDiskFile CSI Drivers with CSI livenessprobe v2.0.0. They worked well. So here make a change that has the minimum impact on the code.
Later I will update the CSI livenessprobe version in AzureDiskFileCSI Drivers repo.
/cc @feiskyer @andyzhangx
Issue Fixed:
Requirements:
Notes: