-
Notifications
You must be signed in to change notification settings - Fork 522
feat: add support for Kubernetes 1.21.0-beta.1 #4321
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4321 +/- ##
=======================================
Coverage 72.07% 72.07%
=======================================
Files 141 141
Lines 21640 21640
=======================================
Hits 15596 15596
Misses 5093 5093
Partials 951 951
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
a6d9a93
to
1799771
Compare
1799771
to
6489a72
Compare
@marosset @jsturtevant 1.21.0-beta.1 + containerd looks to have a regression compared to beta.0:
Any thoughts? |
2019-datacenter-core-smalldisk-containerd-2103
Do you want to include that change in this PR or should I open another one? |
@marosset I'll make the change here, yay for the clear resolution! |
We enabled some functionality in k/k for containerd that that requires the Windows nodes have at least the Oct 2020 security patches. The image being used by the e2e tests here has May 2020 security patches :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
test/e2e/engine/template.go
Outdated
@@ -261,7 +261,7 @@ func Build(cfg *config.Config, masterSubnetID string, agentSubnetIDs []string, i | |||
prop.WindowsProfile.ImageVersion == "" { | |||
prop.WindowsProfile.WindowsPublisher = "microsoft-aks" | |||
prop.WindowsProfile.WindowsOffer = "aks-windows" | |||
prop.WindowsProfile.WindowsSku = "2019-datacenter-core-smalldisk-containerd-2005" | |||
prop.WindowsProfile.WindowsSku = "2019-datacenter-core-smalldisk-containerd-2103" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops sorry this needs to be 2019-datacenter-core-ctrd-2103
@@ -51,7 +51,7 @@ | |||
"sshEnabled": true, | |||
"windowsPublisher": "microsoft-aks", | |||
"windowsOffer": "aks-windows", | |||
"windowsSku": "2019-datacenter-core-smalldisk-containerd-2005", | |||
"windowsSku": "2019-datacenter-core-smalldisk-containerd-2103", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above (2019-datacenter-core-ctrd-2103)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, marosset, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.21.md#changelog-since-v1210-beta0
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
Requirements:
Notes: