fix: update ingressSecretMap even when secret is malformed #1070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes
.Description
This PR fixes an issue in processing ingress event with TLS secret.
When ingress is processed, the referenced TLS secret is mapped to ingress and saved in a ingress-secret map.
In specific case where secret is malformed,, this step is skipped due to the
continue
statement. So later, when the certificate is fixed, it doesn't cause an event on AGIC and doesn't update the Application Gateway.Secret is malformed in case customer is using a certificate manager which creates an empty secret initially and then fills the cert crt and key after generating them.
This is the place where secret handler checks if the secret is in the map or not.
application-gateway-kubernetes-ingress/pkg/k8scontext/secrets_handlers.go
Line 55 in 6bc8764
Fixes
Closes #893
Closes #728
Closes #763