Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add test for case where an empty secret is populated later #1131

Merged
merged 2 commits into from Feb 5, 2021

Conversation

akshaysngupta
Copy link
Member

@akshaysngupta akshaysngupta commented Feb 5, 2021

Checklist

  • The title of the PR is clear and informative
  • If applicable, the changes made in the PR have proper test coverage
  • Issues addressed by the PR are mentioned in the description followed by Fixes.

Description

This PR adds an E2E for a case where an empty secret is created without certificate information and is later populated with cert and key.
This simulates a case similar to Let's Encrypt where cert maybe empty in the beginning.

apiVersion: v1
kind: Secret
metadata:
  name: testsecret-tls
type: kubernetes.io/tls
data:
  tls.crt: ""
  tls.key: ""

Related to: #1070

Fixes

@akshaysngupta akshaysngupta changed the title test: add test for case where an empty secret is populated later e2e: add test for case where an empty secret is populated later Feb 5, 2021
@akshaysngupta akshaysngupta merged commit ee7d072 into master Feb 5, 2021
@akshaysngupta akshaysngupta deleted the aksgupta/e2e/secretMap branch February 5, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants