Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional text for marketplace powershell and make password length test a warning #636

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Add additional text for marketplace powershell and make password length test a warning #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions arm-ttk/Test-AzMarketplacePackage.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ Test-AzMarketplacePackage validates a package to verify if it passes all the min

$ttkErrors

Write-Host "Please fix any failed tests flagged above. All failed tests must be fixed before submission."
Write-Host "In addition please review the warnings below and fix them. It is highly recommended to fix these to ensure your customers are able to use your application without issues."
Write-Host "For details on fixing these, please check https://aka.ms/arm-ttk-docs"

$ttkWarnings | Where-Object Errors | ForEach-Object {
$_.Warnings = @(foreach ($err in $_.Errors) {
Write-Warning -Message "$err" *>&1
Expand Down
2 changes: 1 addition & 1 deletion arm-ttk/testcases/CreateUIDefinition/PasswordBoxes-Must-Have-Min-Length.test.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ foreach ($pwb in $passwordBoxes) { # Loop over each password box
$totalMins += $match.Groups['Min'].Value -as [int]
}
if ($passWordMinLength -gt $totalMins) {
Write-Error "PasswordBox '$($pwb.Name)' regex does not have a minimum length of $PasswordMinLength" -TargetObject $pwb
Write-Warning"PasswordBox '$($pwb.Name)' regex does not have a minimum length of $PasswordMinLength" -TargetObject $pwb
}
}
} catch {
Expand Down