Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typespec): bump to 0.55.0 #4549

Merged
merged 8 commits into from
Apr 11, 2024
Merged

Conversation

archerzz
Copy link
Member

@archerzz archerzz commented Apr 7, 2024

Description

  • bump typespec and depending libraries to 0.55.0
  • adopt interface change in tcgc
  • update typescript test cases
  • remove deleted projection test case in cadl-ranch
  • regen, nextLink properties are now read/write due to upstream change
  • work around a tcgc bug regarding multiple enum return value

resolve #4528

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

- bump depending typespec and depending libraries to 0.55.0
- adopt interface change in tcgc
- update typescrit test cases
- remove deleted `projection` test case in `cadl-ranch`
- regen, `nextLink` properties are now read/write due to upstream change
- work around a tcgc bug regardin multiple enum return value

resolve Azure#4528
@archerzz
Copy link
Member Author

archerzz commented Apr 9, 2024

This PR is blocked by TCGC bug: Azure/typespec-azure#626

@archerzz
Copy link
Member Author

archerzz commented Apr 9, 2024

Another regression is the ignore of @clientName when it's carried over through is

Azure/typespec-azure#233

Mingzhe Huang (from Dev Box) added 3 commits April 11, 2024 11:20
# Conflicts:
#	test/CadlRanchProjects/projection/projected-name/src/Generated/Internal/ModelSerializationExtensions.cs
#	test/CadlRanchProjects/projection/projected-name/src/Generated/Model.cs
#	test/CadlRanchProjects/projection/projected-name/src/Generated/Models/CSModel.Serialization.cs
#	test/CadlRanchProjects/projection/projected-name/src/Generated/Models/ClientModel.Serialization.cs
#	test/CadlRanchProjects/projection/projected-name/src/Generated/Models/ClientProjectedNameModel.Serialization.cs
#	test/CadlRanchProjects/projection/projected-name/src/Generated/Models/JsonAndClientProjectedNameModel.Serialization.cs
#	test/CadlRanchProjects/projection/projected-name/src/Generated/Models/JsonProjectedNameModel.Serialization.cs
#	test/CadlRanchProjects/projection/projected-name/src/Generated/Models/LanguageProjectedNameModel.Serialization.cs
#	test/CadlRanchProjects/projection/projected-name/src/Generated/Property.cs
#	test/CadlRanchProjects/type/union/src/Generated/EnumsOnly.cs
#	test/CadlRanchProjects/type/union/src/Generated/FloatsOnly.cs
#	test/CadlRanchProjects/type/union/src/Generated/IntsOnly.cs
#	test/CadlRanchProjects/type/union/src/Generated/MixedLiterals.cs
#	test/CadlRanchProjects/type/union/src/Generated/MixedTypes.cs
#	test/CadlRanchProjects/type/union/src/Generated/Models/GetResponse6.Serialization.cs
#	test/CadlRanchProjects/type/union/src/Generated/Models/GetResponse7.Serialization.cs
#	test/CadlRanchProjects/type/union/src/Generated/Models/GetResponse8.Serialization.cs
#	test/CadlRanchProjects/type/union/src/Generated/Models/GetResponse9.Serialization.cs
#	test/CadlRanchProjects/type/union/src/Generated/Models/SendRequest6.Serialization.cs
#	test/CadlRanchProjects/type/union/src/Generated/Models/SendRequest7.Serialization.cs
#	test/CadlRanchProjects/type/union/src/Generated/Models/SendRequest8.Serialization.cs
#	test/CadlRanchProjects/type/union/src/Generated/Models/SendRequest9.Serialization.cs
#	test/CadlRanchProjects/type/union/src/Generated/ModelsOnly.cs
#	test/CadlRanchProjects/type/union/src/Generated/StringAndArray.cs
#	test/CadlRanchProjects/type/union/src/Generated/StringExtensible.cs
#	test/CadlRanchProjects/type/union/src/Generated/StringExtensibleNamed.cs
#	test/CadlRanchProjects/type/union/src/Generated/StringsOnly.cs
@archerzz
Copy link
Member Author

One bug in tcgc: type defined like A | null is not correctly parsed, which breaks Azure.OpenAI.Assistants sdk.

@archerzz
Copy link
Member Author

Preview gen PR: Azure/azure-sdk-for-net#43340

All above issues are resolved.

@archerzz archerzz merged commit e956c83 into Azure:feature/v3 Apr 11, 2024
8 checks passed
@archerzz archerzz deleted the typespec/0.55.0 branch April 11, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update .NET Emitter with the TypeSpec April Release
4 participants