Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typespec): bump to 0.56.0 #4708

Merged
merged 3 commits into from
May 15, 2024
Merged

feat(typespec): bump to 0.56.0 #4708

merged 3 commits into from
May 15, 2024

Conversation

archerzz
Copy link
Member

Description

  • bump typespec and corresponding libraries to the level of version 0.56.0
  • fix unit test case due to deprecated operation template
  • update anonymous return model definition to align with a breaking change

resolve #4699

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

feat(typespec): bump to 0.56.0
0de9de0 
- bump typespec and corresponding libraries to the level of version 0.56.0
- fix unit test case due to deprecated operation template
- update anonymous return model definition to align with a breaking change

resolve Azure#4699
Mingzhe Huang (from Dev Box) added 2 commits May 14, 2024 17:22
@archerzz
Copy link
Member Author

Regen preview: Azure/azure-sdk-for-net#44018
There is no code change.

pshao25
pshao25 approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@pshao25 pshao25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I still think the naming change is a big problem.

@archerzz archerzz merged commit 7c854c2 into Azure:feature/v3 May 15, 2024
8 checks passed
archerzz pushed a commit to archerzz/autorest.csharp that referenced this pull request May 15, 2024
Revert "feat(typespec): bump to 0.56.0 (Azure#4708)"
f563425 
This reverts commit 7c854c2.
archerzz added a commit that referenced this pull request May 15, 2024
@archerzz
Reapply "refacotr(emitter): align file names with `microsoft/typespec… (
de6f275 
#4718)

* Reapply "refacotr(emitter): align file names with `microsoft/typespec`… (#4716)

This reverts commit d6a62a8.

* Revert "feat(typespec): bump to 0.56.0 (#4708)"

This reverts commit 7c854c2.

---------

Co-authored-by: Mingzhe Huang (from Dev Box) <mingzhehuang@microsoft.com>
archerzz added a commit to archerzz/autorest.csharp that referenced this pull request May 16, 2024
@archerzz
feat(typespec): bump to 0.56.0 (Azure#4708)
020c2af 
* feat(typespec): bump to 0.56.0

- bump typespec and corresponding libraries to the level of version 0.56.0
- fix unit test case due to deprecated operation template
- update anonymous return model definition to align with a breaking change

resolve Azure#4699

* fix code gen mismatch

* fix test error

---------

Co-authored-by: Mingzhe Huang (from Dev Box) <mingzhehuang@microsoft.com>
archerzz added a commit that referenced this pull request May 16, 2024
@archerzz
feat(typespec): bump to 0.56.0 (#4708) (#4719)
ebab0f9 
* feat(typespec): bump to 0.56.0

- bump typespec and corresponding libraries to the level of version 0.56.0
- fix unit test case due to deprecated operation template
- update anonymous return model definition to align with a breaking change

resolve #4699

* fix code gen mismatch

* fix test error

---------

Co-authored-by: Mingzhe Huang (from Dev Box) <mingzhehuang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshao25 pshao25 pshao25 approved these changes

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TypeSpec]: Bump to 0.56.0
2 participants
@archerzz @pshao25