This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Consider x-ms-client-name when prechecking for duplicate schemas #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that @pakrym identified in a comment for PR #274 which reported that the Cognitive Search spec was reporting a duplicated schema even after a transform was being used to add
x-ms-client-name
. The change adds a check forx-ms-client-name
when grouping schemas by name for deduplication purposes.I also added an expanded message at @pakrym's request for when a
PreCheck/DuplicateSchema
error is raised:The expanded message informs the user about the
modelerfour.lenient-model-deduplication
setting so that partner teams can turn it on for their specs temporarily before we remove it in a later version.