Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss how TypeSpec unknown is generated in DPG #2078

Closed
Tracked by #2419
joheredi opened this issue Oct 22, 2023 · 3 comments · Fixed by #2546
Closed
Tracked by #2419

Discuss how TypeSpec unknown is generated in DPG #2078

joheredi opened this issue Oct 22, 2023 · 3 comments · Fixed by #2546
Assignees
@qiaozha @v-jiaodi
Labels
HRLC p0 priority 0

Comments

@joheredi
Copy link
Member

joheredi commented Oct 22, 2023 •
edited

Here are the options:

  • Literal translation - Gets generated as unknown
  • Follow the openapi emitter - Generate a any object Record<string, unknown> or Record<string, any> (link)
  • Generate as any
@joheredi joheredi added the DPG label Oct 22, 2023
@joheredi joheredi self-assigned this Oct 22, 2023
@joheredi joheredi mentioned this issue Oct 22, 2023
Merged
@qiaozha
Copy link
Member

qiaozha commented Oct 24, 2023

In the context that we don't split input model and output model, I prefer to generate as any. Because unknown will require customer to guard each access check and any doesn't need this.
Just one point to note here, any -> unknown is a breaking while unknown -> any is not.

@MaryGao
Copy link
Contributor

MaryGao commented Oct 25, 2023 •
edited

Follow the openapi emitter - Generate a any object Record<string, unknown> or Record<string, any>

Not sure I got the point here but I think for openapi the unknown is not a any object but any type see Tim's comment here.

@qiaozha qiaozha mentioned this issue Oct 27, 2023
Open
@MaryGao MaryGao added the HRLC label Oct 27, 2023
@qiaozha
Copy link
Member

qiaozha commented May 21, 2024

I think we have decided to treat unknown as any? #2469 (comment)

@qiaozha qiaozha added the p0 priority 0 label May 23, 2024
This was referenced May 23, 2024
Merged
Open
Merged
@qiaozha qiaozha assigned qiaozha and unassigned joheredi May 24, 2024
@qiaozha qiaozha removed the DPG label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiaozha qiaozha

@v-jiaodi v-jiaodi

Labels
HRLC p0 priority 0
Projects
Generic Core for JS
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

treat-unknown-as-any-in-modular qiaozha/autorest.typescript
4 participants
@MaryGao @joheredi @qiaozha @v-jiaodi