#632 - Updated Private DNS zones to be more dynamic

[chbragg]

Overview/Summary

Optimizes the Private DNS zone creation. Automatically calculates the values for the private DNS zones based on which cloud it is deploying to.

This PR fixes/adds/changes/removes

Fixed #632

Breaking Changes

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• Checked for duplicate Pull Requests
• Associated it with relevant GitHub Issues
• (AVD LZA Team Only) Associated it with relevant ADO Items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

[jamasten]

Well, this looks familiar lol... @chbragg the cloudSuffix for the private DNS zones is needed for air gapped deployments. So, you might be able to remove that unless it's needed for China. I don't recall if I validated the China endpoints with this logic. Did you?

[chbragg]

Thanks @jamasten. I figured why not use some very well written code I saw in another Github repo ;-)

I double checked the China ARM endpoints and they use the same format as USGov cloud so I removed that variable. Thank You!

[danycontre]

@chbragg thanks for your contribution.