Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move global logger to meta wise #537

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jul 2, 2024

Removing the global logger, instead put it per Config/BaseMeta. This makes the module easier to be consumed as a library.

This PR also updates the azlist to include the same change.

@magodo magodo added the enhancement New feature or request label Jul 2, 2024
@magodo magodo requested a review from ms-henglu July 2, 2024 11:57
Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magodo magodo merged commit 6c502ca into Azure:main Jul 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants