This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Refactor/tag creator #732
Merged
Refactor/tag creator #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 27, 2022 13:08
DeagleGross
reviewed
May 30, 2022
src/ArmTemplates/Common/Exceptions/DuplicateTagResourceNameException.cs
Outdated
Show resolved
Hide resolved
src/ArmTemplates/Creator/TemplateCreators/TagTemplateCreator.cs
Outdated
Show resolved
Hide resolved
src/ArmTemplates/Creator/TemplateCreators/TagTemplateCreator.cs
Outdated
Show resolved
Hide resolved
tests/ArmTemplates.Tests/Creator/TemplateCreatorTests/TagTemplateCreatorTests.cs
Outdated
Show resolved
Hide resolved
tests/ArmTemplates.Tests/Creator/TemplateCreatorTests/TagTemplateCreatorTests.cs
Outdated
Show resolved
Hide resolved
tests/ArmTemplates.Tests/Creator/TemplateCreatorTests/TagTemplateCreatorTests.cs
Outdated
Show resolved
Hide resolved
DeagleGross
reviewed
Jun 1, 2022
DeagleGross
approved these changes
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and change behaviour of the tag creator class.
Display name is converted and sanitized to resource name for tags.
Run the tag creator in case there are no tags presented in main configs but only in ApiConfig
Tests introduced for changes
Error messages class created for proper unit testing without duplication of messages.
Closes #730
Fixes #584