Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version of the dependent libraries #322

Closed
FumingZhang opened this issue Nov 5, 2021 · 2 comments
Closed

Fix the version of the dependent libraries #322

FumingZhang opened this issue Nov 5, 2021 · 2 comments

Comments

@FumingZhang
Copy link
Member

FumingZhang commented Nov 5, 2021

Since yesterday, my CI started to report errors when using a fixed version (0.1.32) of azdev to setup azure-cli and the error message is something like ModuleNotFoundError: No module named 'colorama'.

I found the reason is knack removed this lib in PR #249 and so did azdev in PR #321. However, the version of the dependent library knack in azdev's setup.py is not fixed, even if a fixed version of azdev is installed, the latest knack will still be installed through the dependencies, and the colorama library that the old version of azdev depends on is no longer installed.

I would like to ask if the maintainers could fix the version of the dependent libraries to avoid similar issues.

@jiasli
Copy link
Member

jiasli commented Nov 5, 2021

We have removed the problematic knack: Azure/azure-cli#20206

azdev didn't specify the knack version:

Please re-run the pipeline.

@jiasli
Copy link
Member

jiasli commented Nov 5, 2021

We will consider pin knack version in azdev in the future.

@jiasli jiasli closed this as completed Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants