Only install colorama on Windows #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
commented
Sep 17, 2021
| @@ -98,7 +98,7 @@ def __init__(self, | |||
| self.only_show_errors = self.config.getboolean('core', 'only_show_errors', fallback=False) | |||
| self.enable_color = self._should_enable_color() | |||
| # Init colorama only in Windows legacy terminal | |||
| self._should_init_colorama = self.enable_color and os.name == 'nt' and not is_modern_terminal() | |||
| self._should_init_colorama = self.enable_color and sys.platform == 'win32' and not is_modern_terminal() | |||
There was a problem hiding this comment.
Use the same method as setup.py to detect system.
jiasli
commented
Sep 17, 2021
| @@ -5,21 +5,24 @@ | |||
| # Licensed under the MIT License. See License.txt in the project root for license information. | |||
| # -------------------------------------------------------------------------------------------- | |||
|
|
|||
| from codecs import open | |||
There was a problem hiding this comment.
This is for Python 2 which has been dropped long time ago (#233).
|
/azp run |
evelyn-ys
approved these changes
Nov 4, 2021
This was referenced Nov 4, 2021
This was referenced Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As colorama is only initialized on Windows (#238), it should not be installed on Linux or MacOS.