-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azdev scaffolding commands and setup tweaks #85
Conversation
@zikalino @achandmsft here is the PR for the |
@tjprescott thank you! it's pretty large, I will put some comments very soon. |
@zikalino we were planning to more seriously investigate auto-generation of commands from Swagger but decided this has value in its own right and is pretty low-cost. I will likely add an interactive mode for this command (similar to |
@tjprescott I agree, I think we should definitely merge as it definitely creates very good framework that can be extended. |
@@ -225,17 +254,3 @@ | |||
short-summary: > | |||
List the repositories that will be searched for in-development extensions. | |||
""" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was something what was removed before, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks really good. I think it shoudl be merged.
Also very good reference for me on adding new command modules, so i want to use it asap :-)
Thanks @zikalino. I have a few final points that will add the right annotations to the CODEOWNERS file and some other little housekeeping items, but I hope to merge and release today or tomorrow. |
@tjprescott I forgot to mention, I used your branch and have tested it and it works for me! |
I forgot to mention one more thing. I didn't dig any further, perhaps my azure-cli code was out of sync or something like that...
Just at the end of file i removed is_preview=True from following code:
The exception was: The command failed with an unexpected error. Here is the traceback:
|
@zikalino in regards to the |
Fixes #18. Fixes #63.