Skip to content

Commit

Permalink
{CI} Fix check extension name issue (#7154)
Browse files Browse the repository at this point in the history
* test

* Update azdev_linter_style.py

* Update azdev_linter_style.py

* Update azdev_linter_style.py
  • Loading branch information
wangzelin007 committed Jan 5, 2024
1 parent 9a973a2 commit f1f98fc
Showing 1 changed file with 14 additions and 9 deletions.
23 changes: 14 additions & 9 deletions scripts/ci/azdev_linter_style.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
import json
import logging
import os
import re
import shutil
from subprocess import check_call, check_output, CalledProcessError

from pkg_resources import parse_version
from subprocess import CalledProcessError, check_call, check_output

import service_name
from pkg_resources import parse_version
from util import get_ext_metadata

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -93,24 +93,29 @@ def build(self):
self._cmd('azdev extension build {}'.format(self.extension_name))

def check_extension_name(self):
extension_root_dir_name = self.extension_name
original_cwd = os.getcwd()
dist_dir = os.path.join(original_cwd, 'dist')
files = os.listdir(dist_dir)
logger.info(f"wheel files in the dist directory: {files}")
logger.info(f"extension name is: {self.extension_name}")
for f in files:
if f.endswith('.whl'):
NAME_REGEX = r'(.*)-\d+.\d+.\d+'
extension_name = re.findall(NAME_REGEX, f)[0]
extension_name = extension_name.replace('_', '-')
logger.info(f"extension name is: {extension_name}")
ext_file = os.path.join(dist_dir, f)
break
metadata = get_ext_metadata(dist_dir, ext_file, self.extension_name)
logger.info(f"metadata name in setup.py is: {metadata['name']}")
metadata = get_ext_metadata(dist_dir, ext_file, extension_name)
pretty_metadata = json.dumps(metadata, indent=2)
logger.info(f"metadata in the wheel file is: {pretty_metadata}")
shutil.rmtree(dist_dir)
if '_' in self.extension_name:
if '_' in extension_root_dir_name:
raise ValueError(f"Underscores `_` are not allowed in the extension root directory, "
f"please change it to a hyphen `-`.")
if metadata['name'] != self.extension_name:
if metadata['name'] != extension_name:
raise ValueError(f"The name {metadata['name']} in setup.py "
f"is not the same as the extension name {self.extension_name}! \n"
f"is not the same as the extension name {extension_name}! \n"
f"Please fix the name in setup.py!")


Expand Down

0 comments on commit f1f98fc

Please sign in to comment.