Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating CLI extension for Azure Quantum #1879

Merged
merged 76 commits into from Feb 1, 2021
Merged

Creating CLI extension for Azure Quantum #1879

merged 76 commits into from Feb 1, 2021

Conversation

anpaz
Copy link
Contributor

@anpaz anpaz commented Jun 12, 2020


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/anpaz-msft/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

@yonzhan yonzhan requested a review from qwordy June 12, 2020 10:51
@yonzhan yonzhan added this to the S171 milestone Jun 12, 2020
src/quantum/HISTORY.rst Outdated Show resolved Hide resolved
src/quantum/README.rst Show resolved Hide resolved
src/quantum/azext_quantum/_client_factory.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/_client_factory.py Show resolved Hide resolved
src/quantum/azext_quantum/_help.py Show resolved Hide resolved
src/quantum/azext_quantum/_validators.py Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
src/quantum/azext_quantum/_params.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/_validators.py Show resolved Hide resolved
src/quantum/azext_quantum/_validators.py Show resolved Hide resolved
src/quantum/azext_quantum/_validators.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/commands.py Show resolved Hide resolved
src/quantum/azext_quantum/profiles.py Outdated Show resolved Hide resolved
src/quantum/setup.cfg Show resolved Hide resolved
src/quantum/setup.py Outdated Show resolved Hide resolved
src/quantum/setup.py Outdated Show resolved Hide resolved
@qwordy
Copy link
Member

qwordy commented Jun 17, 2020

Please use same tense in help.

az quantum -h

Group
    az quantum : Manage Azure Quantum Workspaces and submit jobs to Azure Quantum Providers.
        This command group is in preview. It may be changed/removed in a future release.
Subgroups:
    job       : Manage jobs for Azure Quantum.
    target    : Manage execution targets for Azure Quantum workspaces.
    workspace : Manage Azure Quantum workspaces.

Commands:
    execute   : Submits a job for quantum execution on Azure Quantum, and waits for the result.

src/quantum/README.rst Outdated Show resolved Hide resolved
src/quantum/README.rst Outdated Show resolved Hide resolved
src/quantum/README.rst Outdated Show resolved Hide resolved
@qwordy
Copy link
Member

qwordy commented Jul 10, 2020

Are you still working on this PR?

@yungezz
Copy link
Member

yungezz commented Jul 20, 2020

hi @anpaz-msft are you still on this PR? If yes, could you pls look at comments and fix CI failure? Feel free to ping us if any question.

@yungezz
Copy link
Member

yungezz commented Aug 5, 2020

ping @anpaz-msft again for update

@yungezz yungezz removed this from the S171 milestone Aug 5, 2020
@anpaz
Copy link
Contributor Author

anpaz commented Aug 10, 2020

Based on feedback I received offline, I was requested to hold this until Azure Quantum service in in public preview; currently we are on Private Preview.

@anpaz anpaz requested a review from kairu-ms as a code owner January 29, 2021 03:21
@Azure Azure deleted a comment from yonzhan Jan 29, 2021
@qwordy
Copy link
Member

qwordy commented Feb 1, 2021

@anpaz @ricardo-espinoza Thank you for your work on this PR! It is really a large PR. I will merge it now. I created a issue #2956. We can discuss and resolve them in later releases.

@qwordy qwordy merged commit 12f5b10 into Azure:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants