Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure quantum extension v0 #2

Merged
merged 48 commits into from
Jun 12, 2020
Merged

Azure quantum extension v0 #2

merged 48 commits into from
Jun 12, 2020

Conversation

anpaz
Copy link
Owner

@anpaz anpaz commented Jun 3, 2020

All the changes made for the az quantum extension.

Please ignore all files un .\src\quantum\azext_quantum\vendored_sdks\ since these are all auto-generated using autorest.

Everything else is fair game :).

@anpaz anpaz requested review from cgranade and bamarsha June 3, 2020 23:25
cgranade
cgranade reviewed Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@cgranade cgranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I didn't know how to read through the YAML files for tests, but other than that I read through all of the non-vendored code and left comments. Thanks!

src/quantum/azext_quantum/_help.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/_validators.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/_validators.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/azext_metadata.json Outdated Show resolved Hide resolved
src/quantum/azext_quantum/commands.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/tests/latest/utils.py Show resolved Hide resolved
src/quantum/setup.py Outdated Show resolved Hide resolved
src/quantum/setup.py Outdated Show resolved Hide resolved
src/quantum/setup.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/custom.py Outdated Show resolved Hide resolved
anpaz
anpaz commented Jun 11, 2020
View reviewed changes
Copy link
Owner Author

@anpaz anpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkmark

.github/CODEOWNERS Show resolved Hide resolved
src/quantum/azext_quantum/operations/__init__.py Show resolved Hide resolved
@anpaz
Copy link
Owner Author

anpaz commented Jun 12, 2020

Thanks @cgranade for the great feedback, as usual.
I've incorporated most of your changes. I'll merging these changes and then start a review with the CLI team to start the PR into the prod repo.

@anpaz anpaz merged commit 9ddc0e4 into master Jun 12, 2020
ricardo-espinoza pushed a commit that referenced this pull request Jan 22, 2021
@Anumita
Added --enable-azure-rbac flag in ManagedClusterAadProfile (#2) (Azur…
0ee6b82 
…e#1887)

* Added --enable-azure-rbac flag in ManagedClusterAadProfile (#2)

* Changed flag to enable-azure-rbac instead of aad-enable-azure-rbac

* resolving comment for akspreview

* Regenerated recordings for aks-preview ingress appgw

Co-authored-by: root <root@anshenoVM.da12rmhqn3xunlrjlf1ytzev1d.bx.internal.cloudapp.net>
anpaz added a commit that referenced this pull request May 4, 2021
@anpaz @ricardo-espinoza @qwordy
Creating CLI extension for Azure Quantum (Azure#1879)
12f5b10 
* Azure quantum extension v0 (#2)

Initial version.

* Fixing style issues

* Incorporating feedback (#6)

* readme
* feedback

* Help

* Make storage account optional (#7)

* Storage is now optional (#8)

* Making storage an argument, not an env variable (#9)

* Adding implementation of 'az quantum workspace delete' command.

* Setting new temporary version.

* Fixing missing file in test change

* Adding details to README.md (#5)

* Updating generated files for Azure Quantum resource manager from new swagger file version

* Remove manual edit of generated file.

* Updating generated files for Azure Quantum data plane from new swagger file version

* Updating generated files for Azure Quantum resource manager from new swagger file version. (2020-11-06) (#13)

* Adding implementation of 'az quantum workspace create' command. (#14)

Adding initial implementation of 'az quantum workspace create' command.

-----------------------------------
Command
az quantum workspace create : Creates a new Azure Quantum workspace.
Command group 'quantum' is in preview. It may be changed/removed in a future
release.
Arguments
--location -l : Location. Values from: az account list-locations. You can configure
the default location using az configure --defaults location=<location>.
--resource-group -g : Name of resource group. You can configure the default group using az configure --defaults group=<name>.
--storage_account -sa : Name of the storage account to be used by a quantum workspace.
--workspace-name -w : Name of the Quantum Workspace. You can configure the default workspace
using az quantum workspace set.

* Update Azure CLI quantum extension to multi-region (#17)

This change will set the URL for the data plan API accordingly with a location parameter specified as part of the command.

* Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr. (#16)

Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr.

* Fixing tests for multi-region URL change on Az CLI quantum extension (#19)

Fixing tests for multi-region URL change on Az CLI quantum extension

* Incorporating ARM feedback  (#18)

* Picking up latest changes from swagger after ARM feedback

* updated create_or_update

* run command

* Setting default location in workspace calls if not specified (#20)

* updating python azure quantum rest client (#21)

* Update generated files from swagger file (Version 2021-01-11) (#22)

* Hot fixes on December 2020 release of Azure CLI extension (#23)

* Fixing issue with over specification of location
* Updating version information of extension

* Update CLI with generated clients from more recent swagger files (#24)

- Data plane updated to official swagger file (2021-01-11 19:01:32 UTC) on azure-rest-api-specs @ 98ae52b.

- Resource manager updated to candidate swagger file (2021-01-15 19:35:41 UTC) on anpaz:quantum/resource-manager @ a9a9e271c13500aa54fdbb1bcb656eb61d82d38b.

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Require location as a mandatory parameter in workspace specification (#25)

* Make location mandatory in commands
* Update test recordings

* Resetting the version history for the released version.

* Fix description of workspace clear command

* Updatig Readme file to RST format.

* Update Readme file per pull request comments.

* Fixing az quantum run and execute commands to include location parameter

* Performing role assignment on storage account on workspace creation. (#29)

* Add warning message about providers during workspace creation (#30)

* Enable command az quantum workspace quotas (#31)

* Removing extra space in Readme.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Fix punctuation in Readme.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Update src/quantum/README.rst

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* Update src/quantum/azext_quantum/_params.py

Co-authored-by: Feiyue Yu <iamyfy@163.com>

* First round of code review feedback on Readme.rst

* Improve code readability on job commands

* Avoid IndexError in case of malformed URL

* Extended info on targetId parameter

* Add help to each individual command

* Reorganize sections in Readme.rst and merge in a single set of instructions.

* Static analysis fixes

* Fix CLI Linter errors

* Fix CLI Linter errors. Part 2

* Fix typo in show command.

* Fix show command for Linter

* Use standard name for show command method

* Modify workspace create test to skip role assignment

* Update tests with workspace names used currently.

* Update test recordings.

* Set subscription for the recordings.

* Update test recordings.

* Update QDK version number

* Remove asserts and checks for subscription

* Experiment: Remove check for preview subscription

* Refresh recordings with current test values.

* Update recordings after typo fix.

* Remove commented out API that references subscription

* Enable QuantumJobsScenarioTest.test_submit_args only on live mode

Co-authored-by: Ricardo Espinoza <ricardoe@microsoft.com>
Co-authored-by: Feiyue Yu <iamyfy@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgranade cgranade cgranade left review comments

@bamarsha bamarsha Awaiting requested review from bamarsha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@anpaz @cgranade @bamarsha