[vmware] global reach connections #3528
Conversation
|
vmware |
|
Hi @Juliehzl, can I please get a review? |
src/vmware/azext_vmware/tests/latest/test_global_reach_connection_scenario.py
Outdated
Show resolved
Hide resolved
| with self.command_group('vmware global-reach-connection', vmware_sdk, client_factory=cf_vmware) as g: | ||
| g.custom_command('create', 'globalreachconnection_create') | ||
| g.custom_command('list', 'globalreachconnection_list') | ||
| g.custom_command('delete', 'globalreachconnection_delete') |
There was a problem hiding this comment.
what about add confirmation for delete command?
There was a problem hiding this comment.
I'm going to assume no. I've asked the PM. The only delete that confirms right now is private-cloud. If the PM comes back with a different answer, I'll put in another PR.
| @@ -11,6 +11,7 @@ Other changes: | |||
| - Add `az vmware addon hcx` command group to manage a HCX addon | |||
| - Add `az vmware addon srm` command group to manage a Site Recovery Manager (SRM) addon | |||
| - Add `az vmware addon vr` command group to manage a vSphere Replication (VR) addon | |||
| - Add `az vmware global-reach-connection` command group to manage Global Reach Connections | |||
There was a problem hiding this comment.
I see there are many features in 3.0, but not released. Do you still have new features to add? If not, recommend to upgrade version in setup.py here. Or will you raise a new PR to upgrade the version in setup.py tp trigger our extension release pipeline?
There was a problem hiding this comment.
The new API is still behind a feature flag in production. After the feature flag is removed, I'll create a new PR to upgrade the version in setup.py to trigger the release.
|
@Juliehzl, are you able to merge this? Are there any outstanding concerns? |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.