Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{AKS} Fix enabled virtual node addon showing wrong status in aks addon list #5099

Merged
merged 3 commits into from
Jul 13, 2022
Merged

{AKS} Fix enabled virtual node addon showing wrong status in aks addon list #5099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
387dd44
{AzureKubernetesService} fixes Azure/azure-cli-extensions#5098
navba-MSFT Jul 11, 2022
466fa8f
Update HISTORY.rst
navba-MSFT Jul 12, 2022
4057466
Update setup.py
navba-MSFT Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ If there is no rush to release a new version, please just add a description of t
To release a new version, please select a new version number (usually plus 1 to the minor of the current latest version number), and then add a new section named as the new version number in this file, the content should include the new modifications and everything from the *Pending* section. Finally, update the `VERSION` in `setup.py` with this new version number.

Pending
+++++++
0.5.89
++++++

* Fix for the az aks addon list command to return enable:true, if virtual-node addon is enabled for the AKS cluster.

+++++++
0.5.88
++++++
Expand Down
8 changes: 8 additions & 0 deletions src/aks-preview/azext_aks_preview/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,6 +1383,7 @@ def aks_addon_list_available():
def aks_addon_list(cmd, client, resource_group_name, name):
mc = client.get(resource_group_name, name)
current_addons = []
os_type = 'Linux'

for name, addon_key in ADDONS.items():
# web_application_routing is a special case, the configuration is stored in a separate profile
Expand All @@ -1402,6 +1403,13 @@ def aks_addon_list(cmd, client, resource_group_name, name):
mc.addon_profiles[addon_key].enabled
else False
)
if name == "virtual_node":
addon_key += os_type
enabled = (
True
if addon_key in mc.addon_profiles and mc.addon_profiles[addon_key].enabled
else False
)
current_addons.append({
"name": name,
"api_key": addon_key,
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from setuptools import setup, find_packages

VERSION = "0.5.88"
VERSION = "0.5.89"
CLASSIFIERS = [
"Development Status :: 4 - Beta",
"Intended Audience :: Developers",
Expand Down