Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Add test for virtual node addon in aks addon list #5113

Merged
merged 4 commits into from
Jul 13, 2022

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Jul 13, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Add test for virtual node addon in aks addon list. Also fix the issue again. Patch PR #5099.

Related command

az aks addon list

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 July 13, 2022 03:23
@ghost ghost assigned zhoxing-ms Jul 13, 2022
@ghost ghost added this to the Jul 2022 (2022-08-02) milestone Jul 13, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Jul 13, 2022
@ghost ghost requested a review from yonzhan July 13, 2022 03:23
@ghost ghost added the AKS label Jul 13, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 13, 2022

AKS

@FumingZhang FumingZhang marked this pull request as ready for review July 13, 2022 09:12
@FumingZhang
Copy link
Member Author

Queued a pipeline to test the modified test case test_aks_create_with_virtual_node_addon. All passed.

@zhoxing-ms zhoxing-ms merged commit db42fa9 into Azure:main Jul 13, 2022
@FumingZhang FumingZhang deleted the fuming/addon-list-test-0713 branch July 19, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants