Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if validation_method and raise exception before using it #6481

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Add check if validation_method and raise exception before using it #6481

merged 1 commit into from
Jul 12, 2023

Conversation

dylan8902
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp hostname bind --hostname something.test.net -g MY-GROUP -n my-container-app -e my-container-app-env

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @dylan8902,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jul 5, 2023
@ghost
Copy link

ghost commented Jul 5, 2023

Thank you for your contribution dylan8902! We will review the pull request and get back to you soon.

@ghost ghost requested a review from yonzhan July 5, 2023 22:06
@ghost ghost added the Auto-Assign Auto assign by bot label Jul 5, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 5, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@dylan8902
Copy link
Contributor Author

Fixes #6480

Copy link

@ElleTojaroon ElleTojaroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@zhoxing-ms zhoxing-ms merged commit cb2591c into Azure:main Jul 12, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants