Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mesh upgrade commands for az aks mesh #6775

Merged
merged 54 commits into from
Oct 12, 2023
Merged

Add mesh upgrade commands for az aks mesh #6775

merged 54 commits into from
Oct 12, 2023

Conversation

deveshdama
Copy link
Contributor

Add mesh upgrade commands for az aks mesh

az aks mesh get-upgrades -g rg-name -n mc-name
az aks mesh get-revisions -l location

Related command

  • az aks mesh get-upgrades -g rg-name -n mc-name
  • az aks mesh get-revisions -l location
  • az aks mesh upgrade start --revision mesh-revision -g rg-name -n mc-name
  • az aks mesh upgrade complete -g rg-name -n mc-name
  • az aks mesh upgrade rollback -g rg-name -n mc-name

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

deveshdama and others added 28 commits September 1, 2023 01:26
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 19, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks mesh enable cmd aks mesh enable added parameter revision
⚠️ 1001 - CmdAdd aks mesh get-revisions cmd aks mesh get-revisions added
⚠️ 1001 - CmdAdd aks mesh get-upgrades cmd aks mesh get-upgrades added
⚠️ 1011 - SubgroupAdd aks mesh upgrade sub group aks mesh upgrade added

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/aks-preview/HISTORY.rst Outdated Show resolved Hide resolved
@@ -7488,6 +7488,56 @@ def test_aks_azure_service_mesh_with_pluginca(self, resource_group, resource_gro
self.is_empty(),
])

@AllowLargeResponse()
@AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='westus2')
def test_aks_azure_service_mesh_upgrade_commands(self, resource_group, resource_group_location):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems some new test cases were added, queued new live test validation.

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

live test passed

@yanzhudd yanzhudd merged commit ddd3098 into Azure:main Oct 12, 2023
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=96202&view=results

bgashirabake pushed a commit to bgashirabake/azure-cli-extensions that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants