Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quantum extension - obfuscating E2E test recordings #7144

Conversation

kikomiss
Copy link
Contributor

@kikomiss kikomiss commented Jan 3, 2024

HOTFIX FOR E2E TESTS - RELEASE OF "AZ QUANTUM" EXTENSION IS NOT NEEDED

Fixing an issue with e2e tests for quantum extension where test recording obfuscation fails in PowerShell 7

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

N/A

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jan 3, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @kikomiss,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @kikomiss,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 3, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@kairu-ms kairu-ms merged commit f86f05b into Azure:main Jan 4, 2024
17 of 18 checks passed
@kikomiss kikomiss deleted the users/kikomiss/fix/quantum-ext-e2e-test-obfuscation branch January 4, 2024 02:45
ddouglas-msft pushed a commit to ddouglas-msft/azure-cli-extensions that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Quantum az quantum
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants