Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch link to vcenter #7218

Merged
merged 17 commits into from
Mar 1, 2024
Merged

Conversation

nascarsayan
Copy link
Contributor

@nascarsayan nascarsayan commented Jan 27, 2024


  • Add command az connectedvmware create-from-machines.
  • Delete HCRP Machine resource by default during delete vm. To retain, use --retain-machine flag.
  • Use GA API Version for VCENTER_KIND_GET_API_VERSION.
  • Set extension to non-preview and update version to 1.0.0

Related command

az connectedvmware

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jan 27, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️connectedvmware
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd connectedvmware vm create-from-machines cmd connectedvmware vm create-from-machines added
⚠️ 1006 - ParaAdd connectedvmware vm delete cmd connectedvmware vm delete added parameter retain_machine

Copy link

Hi @nascarsayan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 27, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 25, 2024

Please fix CI issues.

@nascarsayan
Copy link
Contributor Author

nascarsayan commented Feb 26, 2024

Please fix CI issues.

The CI failure looks to be unrelated to the code changes. It failed because it was unable to authenticate to the nuget endpoint while downloading the CredScan tool. Link

Pipeline failures started 2 days back - I can see other PRs failing with same error.

Attempting to gather dependency information for package 'Microsoft.Security.CredScan.2.1.17' with respect to project 'D:\a\_work\_sdt', targeting 'Any,Version=v0.0'
MSBuild auto-detection: using msbuild version '16.11.2.50704' from 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\bin'.
Using credentials from config. UserName: VssSessionToken
WARNING: The plugin credential provider could not acquire credentials. Authentication may require manual action. Consider re-running the command with --interactive for `dotnet`, /p:NuGetInteractive="true" for MSBuild or removing the -NonInteractive switch for `NuGet`
Unable to load the service index for source https://pkgs.dev.azure.com/secdevtools/_packaging/SecDevTools/nuget/v3/index.json.
  Response status code does not indicate success: 401 (Unauthorized).
##[command]"NuGet.exe" install Microsoft.Security.CredScan -Source https://pkgs.dev.azure.com/secdevtools/_packaging/SecDevTools/nuget/v3/index.json -Version 2.1.17 -ConfigFile D:\a\_work\_sdt\dt.nuget.config -NonInteractive

@nascarsayan nascarsayan marked this pull request as ready for review February 26, 2024 03:29
@wangzelin007
Copy link
Member

Please fix CI issues.

The CI failure looks to be unrelated to the code changes. It failed because it was unable to authenticate to the nuget endpoint while downloading the CredScan tool. Link

Pipeline failures started 2 days back - I can see other PRs failing with same error.

Attempting to gather dependency information for package 'Microsoft.Security.CredScan.2.1.17' with respect to project 'D:\a\_work\_sdt', targeting 'Any,Version=v0.0'
MSBuild auto-detection: using msbuild version '16.11.2.50704' from 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\bin'.
Using credentials from config. UserName: VssSessionToken
WARNING: The plugin credential provider could not acquire credentials. Authentication may require manual action. Consider re-running the command with --interactive for `dotnet`, /p:NuGetInteractive="true" for MSBuild or removing the -NonInteractive switch for `NuGet`
Unable to load the service index for source https://pkgs.dev.azure.com/secdevtools/_packaging/SecDevTools/nuget/v3/index.json.
  Response status code does not indicate success: 401 (Unauthorized).
##[command]"NuGet.exe" install Microsoft.Security.CredScan -Source https://pkgs.dev.azure.com/secdevtools/_packaging/SecDevTools/nuget/v3/index.json -Version 2.1.17 -ConfigFile D:\a\_work\_sdt\dt.nuget.config -NonInteractive

We have sent an email to Microsoft Security Code Analysis Support for help, thank you for your reminder.

@jsntcy
Copy link
Member

jsntcy commented Feb 28, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@wangzelin007
Copy link
Member

Add @yanzhudd and @ReaNAiveD to help review this PR.

@yanzhudd
Copy link
Contributor

yanzhudd commented Mar 1, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd
Copy link
Contributor

yanzhudd commented Mar 1, 2024

Please fix the CI issues.

@nascarsayan
Copy link
Contributor Author

Please fix the CI issues.

All the failures are happening due to appservice-kube extension, which were not happening before. The failures might be happening because this PR got merged without the CI build tests running?

@yanzhudd
Copy link
Contributor

yanzhudd commented Mar 1, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd
Copy link
Contributor

yanzhudd commented Mar 1, 2024

The CI has passed after re-running.

nascarsayan and others added 2 commits March 1, 2024 11:56
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
@yanzhudd yanzhudd merged commit 56151c9 into Azure:main Mar 1, 2024
15 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Mar 1, 2024

[Release] Update index.json for extension [ connectedvmware ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=135724&view=results

@nascarsayan nascarsayan deleted the batch-link-to-vcenter branch March 3, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants