Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[az fleet] RP now defaults dns_name_prefix, remove az defaulting #7451

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

jim-minter
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 2, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @jim-minter,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 2, 2024

az fleet

@Ealianis
Copy link
Contributor

Ealianis commented Apr 2, 2024

LGTM!

Copy link

github-actions bot commented Apr 8, 2024

⚠️ Suggestions

Module: fleet

  • Update version to 1.1.1 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@kairu-ms kairu-ms merged commit 97a89b8 into Azure:main Apr 8, 2024
17 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Apr 8, 2024

[Release] Update index.json for extension [ fleet ] : https://dev.azure.com/azclitools/release/_build/results?buildId=146421&view=results

blackchoey pushed a commit to blackchoey/azure-cli-extensions that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants