{AKS} add --sku to az aks create/update command #7478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter sku |
||
| aks update | cmd aks update added parameter sku |
|
AKS |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
FumingZhang
reviewed
Apr 9, 2024
FumingZhang
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Queued live test.
- test_aks_automatic_sku
Seems the feature is not enabled everywhere. Please use custom feature header to bypass or exclude the case from the default test matrix used by cli runner. src/aks-preview/azcli_aks_live_test/configs/ext_matrix_default.json
…y cli runner and fixed the other two UT failures
Updated the code to use custom feature header to bypass. |
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
|
FumingZhang
approved these changes
Apr 10, 2024
3 tasks
yanzhudd
approved these changes
Apr 10, 2024
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=147333&view=results |
Merged
4 tasks
blackchoey
pushed a commit
to blackchoey/azure-cli-extensions
that referenced
this pull request
Apr 29, 2024
blackchoey
pushed a commit
to blackchoey/azure-cli-extensions
that referenced
this pull request
Apr 29, 2024
…aused by change in Azure#7478 (Azure#7510)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create --sku
az aks update --sku
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.