Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for log streaming query params #7480

Conversation

jiec-msft
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 9, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @jiec-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 9, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@jiec-msft
Copy link
Contributor Author

Azure Spring Apps internal CLI e2e test passed: https://msazure.visualstudio.com/AzureDMSS/_build/results?buildId=91145578&view=results

@yanzhudd
Copy link
Contributor

yanzhudd commented Apr 9, 2024

It is better to run related tests in live mode for this change to verify if it meets your expectation.

@jiec-msft
Copy link
Contributor Author

It is better to run related tests in live mode for this change to verify if it meets your expectation.

Yes. Commented in previous one.

@jiec-msft
Copy link
Contributor Author

Above ASA internal test is live test against azure resource in azure public cloud. It's another test set comparing to the scenario tests in CLI extension repo.

@yanzhudd yanzhudd merged commit 5a1a733 into Azure:main Apr 9, 2024
15 of 16 checks passed
blackchoey pushed a commit to blackchoey/azure-cli-extensions that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants