Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} remove recording test for get-os-options #7493

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

chengliangli0918
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

'az aks get-os-options -l...' will be deprecated, this recording tests contribute most of calls to this API, so remove this recording test first.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 10, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @chengliangli0918,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 10, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@chengliangli0918 chengliangli0918 changed the title remove recording test for get-os-options {AKS} remove recording test for get-os-options Apr 10, 2024
@yanzhudd yanzhudd merged commit 756a05c into Azure:main Apr 12, 2024
20 checks passed
blackchoey pushed a commit to blackchoey/azure-cli-extensions that referenced this pull request Apr 29, 2024
Co-authored-by: Charlie Li <charlili@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants