-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS]: Remove support for az aks mesh
egress gateway commands
#7790
Conversation
❌Azure CLI Extensions Breaking Change Test
|
AKS |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but should update the major version as this is a breaking change.
@@ -396,23 +396,12 @@ def load_command_table(self, _): | |||
"aks_mesh_enable_ingress_gateway", | |||
supports_no_wait=True, | |||
) | |||
g.custom_command( | |||
"enable-egress-gateway", | |||
"aks_mesh_enable_egress_gateway", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I think you should also delete the command implementations, like function aks_mesh_disable_egress_gateway
in custom.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to keep this if possible as we will likely reintroduce egress gateway in the near future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Niranjan here, we would like to keep it as we see that egress gateway functionality will be reintroduced. This PR is to just remove user/test facing code components. @FumingZhang let us know your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, get it
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=172360&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks mesh enable-egress-gateway -n cluster-name -g rg-name
az aks mesh disable-egress-gateway -n cluster-name -g rg-name
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.