-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Compute} Change KeyVaultClient
to CertificateClient
in vm module
#26991
Conversation
️✔️AzureCLI-FullTest
|
Hi @ReaNAiveD, |
️✔️AzureCLI-BreakingChangeTest
|
It will be great if the PR description can explain why |
Updated |
The new PR description looks perfect! 🎉 |
def create_keyvault_data_plane_client(cli_ctx, vault_base_url): | ||
from azure.cli.command_modules.keyvault._client_factory import data_plane_azure_keyvault_certificate_client | ||
return data_plane_azure_keyvault_certificate_client(cli_ctx, {"vault_base_url": vault_base_url}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This create_keyvault_data_plane_client
function internally calls azure.cli.command_modules.keyvault._client_factory.data_plane_azure_keyvault_certificate_client
which returns a azure.keyvault.certificates.CertificateClient
, making the name of this function no longer valid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
create_keyvault_data_plane_client
functions returns aazure.keyvault.certificates.CertificateClient
, making the name of this function no longer valid.
I see. I will create a new PR to implement this change.
Related command
vm secret add
vm encryption enable
vmss encryption enable
Description
Change
azure.keyvault.KeyVaultClient
toazure.keyvault.certificates.CertificateClient
in vm module.Package
azure-keyvault
is incompatible with Python 3.11, becauseinspect.getargspec
is removed in Python 3.11.Ref: microsoft/knack#275 (comment)
Testing Guide
vm secret add -g myGroup -n vm --keyvault vault --certificate cert
vm encryption enable -g myGroup -n vm --disk-encryption-keyvault vault
vmss encryption enable -g myGroup -n vmss --disk-encryption-keyvault vault
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.