{Packaging} Fix DEB install script #28990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Packaging |
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007,
yonzhan and
jsntcy
jiasli
reviewed
May 20, 2024
| @@ -49,7 +49,7 @@ setup() { | |||
| set -v | |||
| mkdir -p /etc/apt/keyrings | |||
| curl -sLS https://packages.microsoft.com/keys/microsoft.asc | | |||
| gpg --dearmor -o /etc/apt/keyrings/microsoft.gpg | |||
| gpg --dearmor > /etc/apt/keyrings/microsoft.gpg | |||
There was a problem hiding this comment.
An alternative is to use gpg --dearmor -o /etc/apt/keyrings/microsoft.gpg --yes, but switching to the old redirection > is safer.
jiasli
approved these changes
May 20, 2024
|
The same change should be made on https://learn.microsoft.com/en-us/cli/azure/install-azure-cli-linux?pivots=apt. |
|
The document is used in an interactive environment, and the user can handle it when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #28984.
There is no tty in GitHub runner. This error is raised when run
gpg --dearmor -o /etc/apt/keyrings/microsoft.gpg:gpg: cannot open '/dev/tty': No such device or addressThe reason is that this file already exists in the agent:
And
gpgwants to ask:File '/etc/apt/keyrings/microsoft.gpg' exists. Overwrite? (y/N)This PR reverts to the save method from the previous commit, which overwrites the file.
Related PR: #28250
Tested in this workflow: https://github.com/bebound/starter-workflows/actions/runs/9152933588