BotService: 0.1.3 release #8035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te wwwroot folder before new bot is published
|
@stevengum please note that the code complete date has been moved up to 12/13. If you want to get this into the December release, please get your tests re-recorded. |
tjprescott
changed the title
tjprescott
suggested changes
Dec 11, 2018
src/command_modules/azure-cli-botservice/azure/cli/command_modules/botservice/custom.py
Show resolved
Hide resolved
src/command_modules/azure-cli-botservice/azure/cli/command_modules/botservice/kudu_client.py
Show resolved
Hide resolved
|
@tjprescott, thanks for the review! I have one major change that's still a WIP but on track to be done by tonight/tomorrow. After that change gets implemented I'll be rerecording the tests and will wrap up this PR. |
|
@tjprescott, can you review again and let me know if there are any issues? Thanks! |
tjprescott
approved these changes
Dec 13, 2018
This was referenced Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR is for Sprint 51, 12/13/2018)
Changes:
az bot show --msbotand add .bot file decryption support (Fixes: Azbot bot show command with --msbot fails microsoft/botbuilder-tools#720)site/wwwroot/folder duringaz bot publishto get rid of old unused filesKuduClientmethods for emptying folders on Kudulogger.info()calls, fix some incorrect loggingAdditional checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.