Nat Gateway #9373
Merged
Nat Gateway #9373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
suggested changes
May 13, 2019
| @@ -1081,8 +1081,7 @@ def load_arguments(self, _): | |||
| c.argument('use_remote_gateways', action='store_true', help='Allows VNet to use the remote VNet\'s gateway. Remote VNet gateway must have --allow-gateway-transit enabled for remote peering. Only 1 peering can have this flag enabled. Cannot be set if the VNet already has a gateway.') | |||
|
|
|||
| with self.argument_context('network vnet subnet') as c: | |||
| c.argument('subnet_name', arg_type=subnet_name_type, options_list=['--name', '-n'], id_part='child_name_1') | |||
There was a problem hiding this comment.
You need to revert this line. It should not be deleted.
tjprescott
approved these changes
May 13, 2019
tjprescott
added a commit
that referenced
this pull request
May 15, 2019
* Azure CLI Nat Gateway contract changes (#9071) * Azure CLI Nat Gateway contract changes * Update help text to nat gateway sku * Update setup files * Make azure-cli-natgateway installable. * Re-record tests for 2018-02-01. * Re-record tests. * Re-record tests. Remove accidentally committed files. * Nat Gateway Resource (#9147) * Azure CLI Nat Gateway contract changes * Update help text to nat gateway sku * Update setup files * Add Get,Create,Remove commands for Nat Gateway and Test for Create,Remove NatGateway * Update PR comments and tests * Update Recordings * Update recordings. * Nat Gateway Resource (#9330) * Azure CLI Nat Gateway contract changes * Update help text to nat gateway sku * Update setup files * Add Get,Create,Remove commands for Nat Gateway and Test for Create,Remove NatGateway * Update PR comments and tests * Update Recordings * Update linter, style changes, convert update from regular to properties * Update help examples and natgateway properties update * Add ID support * Update Recordings and merge branch to local * Update azure cli pyproj * Attach subnet to Nat Gateway (#9333) * Azure CLI Nat Gateway contract changes * Update help text to nat gateway sku * Update setup files * Add Get,Create,Remove commands for Nat Gateway and Test for Create,Remove NatGateway * Update PR comments and tests * Update Recordings * Update linter, style changes, convert update from regular to properties * Update help examples and natgateway properties update * Add ID support * Update Recordings and merge branch to local * Update azure cli pyproj * Subnet attached to managed nat * Update PR comments * Nat Gateway (#9373) * Azure CLI Nat Gateway contract changes * Update help text to nat gateway sku * Update setup files * Add Get,Create,Remove commands for Nat Gateway and Test for Create,Remove NatGateway * Update PR comments and tests * Update Recordings * Update linter, style changes, convert update from regular to properties * Update help examples and natgateway properties update * Add ID support * Update Recordings and merge branch to local * Update azure cli pyproj * Subnet attached to managed nat * Update PR comments * Updates to NAT gateway module. * Update tests and validator' * Update Params * Rerecord tests. * Re-record tests. * Convert AKS tests to live only. * Convert SQL test to live only. * Final fixes. * Disable flaky security test. * Convert `network nat-gateway` group to `network nat gateway`. * Code review feedback.
leonardbf
added a commit
to leonardbf/azure-cli
that referenced
this pull request
Jun 4, 2019
* ppg create: `--type` is now optional. (Azure#9391) * [functionapps] Improvements of devops-pipeline command (Azure#9383) * role assignment: support scope of management group (Azure#9321) * [function-app]: wording change from iteractive to interactive (Azure#9402) * [Network] NAT Gateway support (Azure#9379) * Azure CLI Nat Gateway contract changes (Azure#9071) * Azure CLI Nat Gateway contract changes * Update help text to nat gateway sku * Update setup files * Make azure-cli-natgateway installable. * Re-record tests for 2018-02-01. * Re-record tests. * Re-record tests. Remove accidentally committed files. * Nat Gateway Resource (Azure#9147) * Azure CLI Nat Gateway contract changes * Update help text to nat gateway sku * Update setup files * Add Get,Create,Remove commands for Nat Gateway and Test for Create,Remove NatGateway * Update PR comments and tests * Update Recordings * Update recordings. * Nat Gateway Resource (Azure#9330) * Azure CLI Nat Gateway contract changes * Update help text to nat gateway sku * Update setup files * Add Get,Create,Remove commands for Nat Gateway and Test for Create,Remove NatGateway * Update PR comments and tests * Update Recordings * Update linter, style changes, convert update from regular to properties * Update help examples and natgateway properties update * Add ID support * Update Recordings and merge branch to local * Update azure cli pyproj * Attach subnet to Nat Gateway (Azure#9333) * Azure CLI Nat Gateway contract changes * Update help text to nat gateway sku * Update setup files * Add Get,Create,Remove commands for Nat Gateway and Test for Create,Remove NatGateway * Update PR comments and tests * Update Recordings * Update linter, style changes, convert update from regular to properties * Update help examples and natgateway properties update * Add ID support * Update Recordings and merge branch to local * Update azure cli pyproj * Subnet attached to managed nat * Update PR comments * Nat Gateway (Azure#9373) * Azure CLI Nat Gateway contract changes * Update help text to nat gateway sku * Update setup files * Add Get,Create,Remove commands for Nat Gateway and Test for Create,Remove NatGateway * Update PR comments and tests * Update Recordings * Update linter, style changes, convert update from regular to properties * Update help examples and natgateway properties update * Add ID support * Update Recordings and merge branch to local * Update azure cli pyproj * Subnet attached to managed nat * Update PR comments * Updates to NAT gateway module. * Update tests and validator' * Update Params * Rerecord tests. * Re-record tests. * Convert AKS tests to live only. * Convert SQL test to live only. * Final fixes. * Disable flaky security test. * Convert `network nat-gateway` group to `network nat gateway`. * Code review feedback. * [ACR] Support Managed Identities for Task (Azure#9317) * [webapp]Fixing bug where the result was not showing the ASP (Azure#9408) * BotService 0.2.1: Update help text, minor UX improvements (Azure#9412) * Add support for Manual-Failover (Azure#9413) * add new command * add support for manual-failover * update help content * re-record test session * Bump SDK version * [core] Fix bug where --query cannot be used with --output yaml (Azure#9403) * [core] Fix bug where --query cannot be used with --output yaml * Add comment explaining yaml formatter error handling logic. * update default log analytics workspace region mapping for aks monitoring addon (Azure#9434) * add cluster spn with metric publisher role to aks cluster resource * refactor the code * fix default workspace issue in china cloud * add metrics publisher role assignment only in public cloud * fix pr feedback * fix build error * fix lint error * update region mapping * order regions in sortorder * fix trailing whitespaces * Fix JP installer line (Azure#9438) Curl must follow redirects. Fixes Azure#9435 * ACS - OSA - Whitelist message (Azure#9409) * add friendly msg when sub is not whitelisted for GA API * bump version and add history * release: update versions (Azure#9418) * [vm] Fix bug introduced in Azure#9306. (Azure#9421) * auth: handle unicode in subscription name when under python 2.7 (Azure#9439) * role: update the help of --assignee-object-id (Azure#9457) * role: update the help of --assignee-object-id * fix grammar * Update error logging for reported unclear issues (Azure#9180) * Update error logging for reported unclear issues * Combine error messages * fix ci * Enable/Disable AKS kube-dashboard addon (Azure#9458) * Disable/Enable kube-dashboard addon * Minor fixes * change HISTORY.rst * Added ACR command to create a buildpack task (Azure#9366) * Added acr pack command scaffold * Added acr pack test * Fixed command registration * Consolidated value * Added command module scaffold * Extracted method * Added linux assertion * Fixed params * Moved validation to be earlier No need to upload sources if the build cannot proceed * Removed --file, added --image * Improved docstring * Added builder flag * Fixed flake9 errors in run.py * Fixed flake8 erros in pack.py * Added registry name env var to build * Removed test * Unused * CR remark * Merge remote-tracking branch 'refs/remotes/Azure/dev' into dev # Conflicts: # src/command_modules/azure-cli-acr/azure/cli/command_modules/acr/run.py * Added task version * Removed unnecessary doc * Removed unused imports * Added no-pull arg * Flipped arg * Added automatic registry prefix * CR * Make the RPM Spec flexible to EL7 vs EL8 (Azure#9394) * Add python3 macro to RPM spec * fixing missed raw python use * fixing another missed raw python use * Don't look for el7, look for el* * Try removing duplicate dependencies in Runtime and buildtime requirements * Declare dependency on virtualenv instead of downloading it * Disable python-devel requirement * WIP * More fixes * Exclude hardlinks created by virtualenv In reality, all we need from virtualenv is an easy way to build up an alternate site-packages directory. Infact, what this is doing just emulates how a virtualenv works, but without the hardlinks that were confusing rpmbuild! * Ignore user site-packages * [ACR] Return patch response directly for acr repository update (Azure#9420) * Return patch response directly for acr repository update * fix ci * Remove deprecated classic registry error handling * Fixing Dockerfile name of RPM builder for centos in pipeline definition (Azure#9493) * test: fix a flaky test (Azure#9494) * Update _help.py (Azure#9502) Corrected a small typo. * Added Error Message when no TTY is available (Azure#9481) * Added Error Message when no TTY is available Fix Azure#3876 When performing a resource group deployment, if no TTY is available, a CLIError will be raised detailing the parameters that were not provided. * Fixes for python2 compatibility * [Network] AppGateway WAF Policy commands (Azure#9470) * initial work. * WAF Policy progress. * Progress. * WAF policy commands and test. * Fix and re-record test. * Closes Azure#9255. * Fix test issue. * Code review feedback. * Fix update logic. * Fix CI * [vm] create now more intelligently uses image data disk lun info. (Azure#9504) * vm create now more intelligently uses image data disk lun information. * Re-record and update a test. Other minor updates. * Update tests. Minor bug fixes. * Upate hybrid profile tests * Fixed registry prefix check (Azure#9509) * Added acr pack command scaffold * Added acr pack test * Fixed command registration * Consolidated value * Added command module scaffold * Extracted method * Added linux assertion * Fixed params * Moved validation to be earlier No need to upload sources if the build cannot proceed * Removed --file, added --image * Improved docstring * Added builder flag * Fixed flake9 errors in run.py * Fixed flake8 erros in pack.py * Added registry name env var to build * Removed test * Unused * CR remark * Merge remote-tracking branch 'refs/remotes/Azure/dev' into dev # Conflicts: # src/command_modules/azure-cli-acr/azure/cli/command_modules/acr/run.py * Added task version * Removed unnecessary doc * Removed unused imports * Added no-pull arg * Flipped arg * Added automatic registry prefix * CR * Fixed registry prefix * Updated history.rst * Update CLI to use Knack 0.6.2 (preview mechanism) (Azure#9456) * Initial work. * Update preview references. * Additional work to wire up preview arguments. * Update for knack changes. * Update dependencies. Remove command suggestion code. Deprecate BatchAI. Hide ACS. * Restore CLI-specific spellchecker. * Update history entries. * Network API 2019-04-01 (Azure#9523) * Re-record tests for 2019-04-01. * Closes Azure#9463. * Closes Azure#9401. Restore private endpoint tests and commands. * support ssh_public_key (Azure#9512) * Fix Azure#9489. (Azure#9531) * Fix Azure#9443. (Azure#9533) * ServiceBus: Fix for Issue 9319 (Azure#9538) * Fix for Issue - 9319 * updated version in histroy and setup files * updated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.