Relay: Fixed issue #8775 : #9900
Merged
+2,956
−1,556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d client authroization
tjprescott
suggested changes
Jul 10, 2019
src/azure-cli/HISTORY.rst
Outdated
| @@ -3,6 +3,11 @@ | |||
| Release History | |||
| =============== | |||
|
|
|||
| **Relay** | |||
There was a problem hiding this comment.
This needs to be alphabetical in the list.
| c.argument('user_metadata', help='Endpoint metadata') | ||
|
|
||
| with self.argument_context('relay wcfrelay update') as c: | ||
| c.argument('relay_name', arg_type=name_type, id_part='child_name_1', help='Name of WCF Relay') | ||
| c.argument('status', arg_type=get_enum_type(['Active', 'Disabled', 'SendDisabled', 'ReceiveDisabled']), help='Enumerates the possible values for the status of a messaging entity.') | ||
| c.argument('relay_type', arg_type=get_enum_type(['Http', 'NetTcp']), default='NetTcp', help='Relay type') | ||
| c.argument('requires_client_authorization', arg_type=get_three_state_flag(), help='Indicates whether client authorization is required') | ||
| c.argument('requires_transport_security', arg_type=get_three_state_flag(), help='Indicates whether transport security is required') |
There was a problem hiding this comment.
You don't need this duplication. This should just be registered under a scope of 'relay wcfrelay'.
There was a problem hiding this comment.
Let me check with PM, as 'requires_client_authorization' and 'requires_transport_security' can be set only at create wcfrelay and can not be changed. I think its should be removed from update command.
tjprescott
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #8775 : Cannot create hybrid connection with disabled client authroization
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.