Improving error messages in windows command execution #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiro-gamarra
changed the title
msvik
approved these changes
Jul 14, 2023
rbtr
approved these changes
Jul 17, 2023
rbtr
pushed a commit
that referenced
this pull request
Sep 8, 2023
improving error messages from executing commands on windows
jpayne3506
pushed a commit
that referenced
this pull request
Sep 11, 2023
improving error messages from executing commands on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change
Debugging CNI Windows logs is not helpful when we cannot see the entirety of what's output by commands failing. This PR attempts to improve these messages by including both stdout and stderr in the error messages returned.