fix: disable ipv6 on transparent vlan mode network create #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipul-21
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
This won't impact existing scenario.
But want to confirm two things:
- dual stack with multitenancy will need to change it again ?
- this is used by multitenancy and won't impact multi nic support(swift 2.0) in aks ?
cc: @tamilmani1989 @paulyufan2
paulyufan2
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Hi @vipul-21
(1) Dualstack support is only for AKS overlay at the moment considered as single tenancy mode
(2) We are not considering ipv6 address support for multi nic for now.
tamilmani1989
approved these changes
Dec 1, 2023
QxBytes
force-pushed
the
alew/block-ipv6
branch
from
59fad31
to
e42c543
Compare
matmerr
pushed a commit
that referenced
this pull request
Jan 17, 2024
Disable ipv6 on transparent vlan mode network create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Ipv6 traffic from within the pod should not be able to reach eth0 on the vm from eth1 in the container. To enforce this, we disable ipv6 on all interfaces in the vm namespace. The vnet namespace has ipv6 forwarding disabled by default so no modification is required on that datapath.
Issue Fixed:
See above.
Requirements:
Notes: