Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate from disallowed registries #2455

Merged
merged 1 commit into from Jan 3, 2024
Merged

chore: migrate from disallowed registries #2455

merged 1 commit into from Jan 3, 2024

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Dec 20, 2023

Reason for Change:

AZP has started auto-injecting a registry scan that has flagged some of our container refs

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr self-assigned this Dec 20, 2023
@rbtr rbtr requested review from a team as code owners December 20, 2023 18:18
@jpayne3506
Copy link
Contributor

/azp run CNI Load Test

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jpayne3506
Copy link
Contributor

LGTM, doing additional smoke testing and will then approve.

huntergregory
huntergregory approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@huntergregory huntergregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPM lgtm

@rbtr rbtr enabled auto-merge December 20, 2023 21:22
@rbtr rbtr force-pushed the chore/remove-disallowed-images branch from a325a47 to 8de655c Compare December 20, 2023 21:50
@rbtr rbtr added this pull request to the merge queue Dec 20, 2023
@rbtr rbtr removed this pull request from the merge queue due to a manual request Dec 20, 2023
@rbtr rbtr force-pushed the chore/remove-disallowed-images branch from 8de655c to 06c988c Compare December 20, 2023 22:35
@rbtr rbtr enabled auto-merge December 20, 2023 22:36
@rbtr rbtr added this pull request to the merge queue Dec 20, 2023
@jpayne3506 jpayne3506 removed this pull request from the merge queue due to a manual request Dec 21, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 21, 2023
@jpayne3506 jpayne3506 removed this pull request from the merge queue due to a manual request Dec 21, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 21, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 23, 2023
@jpayne3506 jpayne3506 removed this pull request from the merge queue due to a manual request Dec 23, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 23, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 23, 2023
@jpayne3506 jpayne3506 added this pull request to the merge queue Dec 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 24, 2023
@rbtr rbtr force-pushed the chore/remove-disallowed-images branch from 06c988c to 4a59bfb Compare December 24, 2023 04:26
@rbtr rbtr enabled auto-merge December 24, 2023 04:26
@rbtr rbtr added this pull request to the merge queue Dec 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 24, 2023
@rbtr rbtr added this pull request to the merge queue Jan 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2024
@jpayne3506 jpayne3506 added this pull request to the merge queue Jan 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 3, 2024
@rbtr
chore: migrate from disallowed registries
4aab411 
Signed-off-by: GitHub <noreply@github.com>
@rbtr rbtr force-pushed the chore/remove-disallowed-images branch from 4a59bfb to 4aab411 Compare January 3, 2024 17:35
@rbtr rbtr enabled auto-merge January 3, 2024 17:35
@rbtr rbtr added this pull request to the merge queue Jan 3, 2024
Merged via the queue into master with commit ad10662 Jan 3, 2024
27 of 33 checks passed
@rbtr rbtr deleted the chore/remove-disallowed-images branch January 3, 2024 20:33
matmerr pushed a commit that referenced this pull request Jan 17, 2024
@rbtr @matmerr
chore: migrate from disallowed registries (#2455)
f8cbaf3 
Signed-off-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alam-tahmid alam-tahmid alam-tahmid approved these changes

@huntergregory huntergregory huntergregory approved these changes

@jpayne3506 jpayne3506 jpayne3506 approved these changes

@estebancams estebancams estebancams approved these changes

Assignees

@rbtr rbtr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rbtr @jpayne3506 @alam-tahmid @huntergregory @estebancams