Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: E2E Framework [Core types] [1/6] #2526

Merged
merged 1 commit into from Jan 22, 2024
Merged

ci: E2E Framework [Core types] [1/6] #2526

merged 1 commit into from Jan 22, 2024

Conversation

matmerr
Copy link
Member

@matmerr matmerr commented Jan 18, 2024 •
edited

Reason for Change:

Objectives

  • Steps are reusable
  • Steps parameters are saved to the context of the job
  • Once written to the job context, the values are immutable
  • Cluster resources used in code should be able to be generated to yaml for easy manual repro
  • Avoid shell/ps calls wherever possible and use go libraries for typed parameters (avoid capturing error codes/stderr/stdout)

Issue Fixed:

Requirements:

Notes:

@matmerr matmerr changed the title ci: E2E Framework [types] ci: E2E Framework [Core types] Jan 18, 2024
@matmerr matmerr marked this pull request as ready for review January 18, 2024 22:50
@matmerr matmerr requested a review from a team as a code owner January 18, 2024 22:50
@matmerr matmerr requested a review from msvik January 18, 2024 22:50
@matmerr matmerr changed the title ci: E2E Framework [Core types] ci: E2E Framework [Core types] [1/5] Jan 18, 2024
@matmerr matmerr mentioned this pull request Jan 18, 2024
Merged
4 tasks
@matmerr matmerr changed the title ci: E2E Framework [Core types] [1/5] ci: E2E Framework [Core types] [1/6] Jan 18, 2024
@matmerr matmerr added this pull request to the merge queue Jan 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 20, 2024
@rbtr rbtr enabled auto-merge January 22, 2024 17:07
@rbtr rbtr added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit c1a5560 Jan 22, 2024
14 checks passed
@rbtr rbtr deleted the matmerr/e2eframework-types branch January 22, 2024 20:00
alam-tahmid pushed a commit that referenced this pull request Jan 26, 2024
@matmerr @alam-tahmid
ci: E2E Framework [Core types] [1/6] (#2526)
e850af6 
add types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbtr rbtr rbtr approved these changes

@vakalapa vakalapa vakalapa approved these changes

@msvik msvik Awaiting requested review from msvik msvik is a code owner automatically assigned from Azure/azure-sdn-members

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matmerr @rbtr @vakalapa