feat: add imds client #2537
Merged
feat: add imds client #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarwal0009
previously approved these changes
Jan 23, 2024
|
there isn't an existing Go IMDS client? 🙁 |
Only one I could find is an archived repo: https://github.com/giantswarm/azure-imds-client |
rbtr
approved these changes
Jan 23, 2024
miguelgoms
approved these changes
Jan 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
alam-tahmid
pushed a commit
that referenced
this pull request
Jan 26, 2024
* feat: add imds client * fix: lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adds an IMDS client to CNS so it can query IMDS to learn its VM Unique ID
Issue Fixed:
Requirements:
Notes:
I double checked the IMDS document and there is nothing I think is sensitive in there, but it would be good for someone else to check it.