feat: create or update nodeinfo crd at cns startup for multitenancy #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nddq
reviewed
Jan 25, 2024
miguelgoms
previously approved these changes
Jan 25, 2024
thatmattlong
dismissed stale reviews from miguelgoms and aggarwal0009
via
b160a03
aggarwal0009
approved these changes
Jan 25, 2024
nddq
approved these changes
Jan 25, 2024
miguelgoms
approved these changes
Jan 25, 2024
alam-tahmid
pushed a commit
that referenced
this pull request
Jan 26, 2024
…2545) * feat: create or update nodeinfo crd at cns startup for multitenancy * fix: spelling on variable name nodeInfoErr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
CNS will write the vm unique id to the nodeinfo crd (or update it, if one already exists) for the node at startup if swift v2 is enabled. This is required because we can't reliably read the vm unique id from the node.Status.NodeInfo.SystemUniqueID property, as it can be reported by kubelet/cadvisor with the wrong endianess.
Requirements:
Notes: