Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding templates for cilium 1.13 #2585

Merged
merged 6 commits into from
Mar 4, 2024
Merged

chore: adding templates for cilium 1.13 #2585

merged 6 commits into from
Mar 4, 2024

Conversation

camrynl
Copy link
Contributor

@camrynl camrynl commented Feb 14, 2024 •
edited

Reason for Change:
Adding 1.13 templates to prep for migration to v1.13.10 in pipelines

  • no changes to cilium-config map (from 1.12)
  • small changes to clusterrole for agent and operator, removed ciliumbgploadbalancerippools and ciliumegressnatpolicies, and now includes
    • ciliumnodeconfigs
    • ciliumloadbalancerippools

Issue Fixed:

Requirements:

Notes:

@camrynl camrynl self-assigned this Feb 14, 2024
@camrynl camrynl requested a review from a team as a code owner February 14, 2024 00:33
@vipul-21
Copy link
Contributor

Lgtm, did we run this on cni release pipeline.?

@camrynl
Copy link
Contributor Author

camrynl commented Feb 21, 2024

I did not get a run on the release pipeline but I did run the PR pipeline and manually set up a cluster with these templates.

@camrynl camrynl requested a review from a team as a code owner February 21, 2024 20:27
@camrynl
Revert "address comment"
ac93cc6 
This reverts commit 7627154.
jpayne3506
jpayne3506 reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@jpayne3506 jpayne3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let run the CNI release test to confirm the changes are 🟢

@camrynl camrynl removed request for a team and neaggarwMS February 22, 2024 00:29
@camrynl camrynl added this pull request to the merge queue Mar 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 1, 2024
@camrynl camrynl added this pull request to the merge queue Mar 4, 2024
Merged via the queue into master with commit a4f3a40 Mar 4, 2024
80 checks passed
@camrynl camrynl deleted the camrynl/13 branch March 4, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipul-21 vipul-21 vipul-21 approved these changes

@jpayne3506 jpayne3506 jpayne3506 approved these changes

@isaac-dasan isaac-dasan Awaiting requested review from isaac-dasan isaac-dasan is a code owner automatically assigned from Azure/azure-sdn-members

Assignees

@camrynl camrynl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camrynl @vipul-21 @jpayne3506