fix: remove unsupported targets when building all binaries #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
previously approved these changes
Feb 15, 2024
tamilmani1989
approved these changes
Feb 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Remove cnm and windows transparent vlan targets when building all binaries * Remove azure ipam from transparent vlan build
jpayne3506
added
the
needs-backport
QxBytes
added a commit
that referenced
this pull request
Feb 28, 2024
* Remove cnm and windows transparent vlan targets when building all binaries * Remove azure ipam from transparent vlan build
jpayne3506
pushed a commit
that referenced
this pull request
Mar 1, 2024
* Remove cnm and windows transparent vlan targets when building all binaries * Remove azure ipam from transparent vlan build
QxBytes
added a commit
that referenced
this pull request
Mar 5, 2024
fix: remove unsupported targets when building all binaries (#2591) * Remove cnm and windows transparent vlan targets when building all binaries * Remove azure ipam from transparent vlan build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The transparent-vlan on windows and cnm scenarios are not supported and binaries for these scenarios should not be built when making all binaries.
Issue Fixed:
Requirements:
Notes:
Specifically, running make all-binaries or make all-binaries-platforms will not generate these binaries